Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a user is logged in to a server and then tries to connect to the same server nothing happens from their point of view #422

Closed
2 tasks done
Rumbles opened this issue Apr 20, 2017 · 1 comment · Fixed by #423

Comments

@Rumbles
Copy link

Rumbles commented Apr 20, 2017

My Setup

  • My OS name and version: openSUSE/Fedora
  • My current app version: 2.4/2.6.1
  • I have tested with the latest application version
  • I can simulate the issue easily

Description

One of our users (running on openSUSE with 2.4) just reported an issue where he told me "I've been kicked out of rocket chat and can't get back in". When I went up the rocket chat electron app was sat on the "Add new server" page. The server list on the left was hidden (we use one server, we advise people to hide it).

When the user typed in the URL for our server to connect, it just showed the same page again with the server name removed (basically reloaded the page and did nothing)

The reason the user had this issue, was that he was logged in to our rocketchat server, so when he tried to connect to the server the app must have decided no action was necessary as he was already connected. I don't know he got in to this state, maybe there is a keyboard shortcut to get to the "Add new server" dialogue that I don't know about and he hit accidentally.

I opened up the server list and clicked on our server and everything was fine.

When I got back to my desk I reproduced the issue on my machine (Fedora/2.6.1)

Current Behavior

The app doesn't tell you anything if you try to connect to a server you are already connected to.

Expected Behavior

The app should either take you to that rocketchat server, or pop up a message telling you you are already connected, to avoid confusion.

@alexbrazier
Copy link
Contributor

@Rumbles I've made a change so that if you type the server name again it will load it, rather than ignoring. Will that resolve your issue?

There is a shortcut Ctrl+N to add a new server, so that may be how it happened. It is also possible to switch servers using Ctrl+1 etc and you can manually select them from the Window menu, without having to open the server list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants