Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell checking no longer working in 2.17.0 #1426

Closed
2 tasks done
cdisabatino opened this issue Dec 4, 2019 · 25 comments · Fixed by #1737
Closed
2 tasks done

Spell checking no longer working in 2.17.0 #1426

cdisabatino opened this issue Dec 4, 2019 · 25 comments · Fixed by #1737

Comments

@cdisabatino
Copy link

cdisabatino commented Dec 4, 2019

My Setup

  • Operating System: Windows 10
  • App Version: 2.17.0
  • Installation type: exe
  • I have tested with the latest version
  • I can simulate the issue easily

After updating from 2.16.2 to 2.17.0 the spell checking no longer works when typing a message.
Nothing wrong gets underlined any more. Downgrading to 2.16.2 makes it work again. The problem is identical on colleagues' computers with version 2.17.0.

I tried the different languages, disabling and enabling spell check completely, etc.

Identical to the ticket : #1362

I installed version 2.17.0 manually by following the ticket : #1399 (comment)

Thanks

@ugzv
Copy link

ugzv commented Dec 5, 2019

I can confirm this. It doesn't work.

@ddbrandonb
Copy link

+1.
We are also seeing some words incorrectly underlined (they are spelled correctly).

@Forage
Copy link

Forage commented Dec 11, 2019

Looks like a regression indeed. It was fixed in 2.16.1 but got broken again in 2.17.0 (as well as 2.17.1) for Ubuntu 19.10.

@Have-a-question-about-this-project

I also see it in 2.17.1, but can't check my locale is set correctly because of #1441

@Sierra1011
Copy link

2.17.0 clients in OpenSUSE and Windows 10, 1909 and 1809, spelling functionality broken for me. Can select a language but it doesn't check any words.

@evaso
Copy link

evaso commented Dec 18, 2019

The same problem for me. Both version 2.17.0 and version 2.17.1 no longer offer spellcheck. The cursor is also no longer visible in the input field.

  • Operating System: Windows 10

@robcalewar
Copy link

robcalewar commented Dec 18, 2019

Same issues here; I manually installed 2.17.0. right clicking the text field > spelling languages > EN_US is selected but if I go to 'browse for language' and select 'en_US.dic' from 'C:\Program Files\Rocket.Chat\resources\dictionaries' I get the error 'Error copying dictionary file: filePath.extname is not a function'

@mcclint680
Copy link

Ditto with the Mac client. Exact same issue

@metalcated
Copy link

Yep, Windows 10 and Ubuntu. Same issue.

@Forage
Copy link

Forage commented Feb 4, 2020

Fixed in 2.17.4

@ugzv
Copy link

ugzv commented Feb 4, 2020

Fixed in 2.17.4

For me, it's still not working.

@cdisabatino
Copy link
Author

For me, not working 2.17.3.

@robcalewar
Copy link

robcalewar commented Feb 4, 2020

Rocketchat version 2.17.5
Windows version 1803

Spellchecking still does not work. I completely uninstalled rocketchat. Delete any folders resembling rocketchat in "C:\Program Files" and in my appdata folder. I then ran a fresh install and the problem persists.

The error I reported in a previous comment still exists.

Same issues here; I manually installed 2.17.0. right clicking the text field > spelling languages > EN_US is selected but if I go to 'browse for language' and select 'en_US.dic' from 'C:\Program Files\Rocket.Chat\resources\dictionaries' I get the error 'Error copying dictionary file: filePath.extname is not a function'

@Forage
Copy link

Forage commented Feb 4, 2020

Strange that it isn't working for some of you. I installed 2.17.4 on Ubuntu and even though the custom dictionaries got removed, because they decided to move to bdic format, the default ones like English gives me red underlines for miss spelled words again.
Spell checking in the just released 2.17.5 works on Ubuntu as well.

@brianochs
Copy link

The 2.17.7 update seems have to restored the spell check feature for me on Windows 10.

@cdisabatino
Copy link
Author

Version 2.17.7 again offers spell check. But very few languages are offered. There is no French while in a previous version, French was offered.

image

@Forage
Copy link

Forage commented Feb 12, 2020

So far French has never been included. You must have added it yourself manually in the past.

@jbpotonnier
Copy link

French was not included, which was OK since it was not getting in the way.
Now it is very irritating, since everything is red.
image

@southpaw5271
Copy link

Also having this issue with all users in our server. Mac, Windows, and Linux are impacted.

@bigornoo
Copy link

bigornoo commented May 7, 2020

Hi,
same issue here :
macOS 10.14.6, rocket.chat client v. 2.17.9 ; server v. 3.2.1. no French spell checking

@eholloway135
Copy link

can confirm.

Windows 10 v1903, Rocket.Chat v 2.17.15 and v 2.17.17, no English spell check

@fenjen
Copy link

fenjen commented Sep 1, 2020

Works for me in 2.17.11. But I want it off - all the time. Unchecking all languages disables spell check, but after a restart, the language is re-enabled -- and so is spell check 🙄

@Forage
Copy link

Forage commented Sep 2, 2020

Works for me in 2.17.11. But I want it off - all the time. Unchecking all languages disables spell check, but after a restart, the language is re-enabled -- and so is spell check roll_eyes

Different problem, different issue to create.

@bellegarde-c
Copy link

Should be really needed to add all available hunspell language dictionnaries.

Or even better, use system dictionnaries on Linux: https://aur.archlinux.org/cgit/aur.git/tree/use-system-dictionaries.patch?h=rocketchat-desktop

@Forage
Copy link

Forage commented Sep 11, 2020

Should be really needed to add all available hunspell language dictionnaries.

Or even better, use system dictionnaries on Linux: https://aur.archlinux.org/cgit/aur.git/tree/use-system-dictionaries.patch?h=rocketchat-desktop

@bellegarde-c been there, won't happen #1077 despite behaviour already being different on different OSes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.