Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should upgrade to libsdformat13 #17873

Closed
EricCousineau-TRI opened this issue Sep 8, 2022 · 2 comments · Fixed by #17913
Closed

Should upgrade to libsdformat13 #17873

EricCousineau-TRI opened this issue Sep 8, 2022 · 2 comments · Fixed by #17913
Assignees
Labels

Comments

@EricCousineau-TRI
Copy link
Contributor

EricCousineau-TRI commented Sep 8, 2022

Not going to be released til end of month, but would be nice to get out in front of it.

Per VC, this came in (yay)! gazebosim/sdformat#1112
Affected code:

// SDF defaults to ±1.0e16 for joints with no limits, see
// http://sdformat.org/spec?ver=1.6&elem=joint#axis_limit.
// Drake marks joints with no limits with ±numeric_limits<double>::infinity()
// and therefore we make the change here.
const double lower_limit =
axis->Lower() == -1.0e16 ?
-std::numeric_limits<double>::infinity() : axis->Lower();
const double upper_limit =
axis->Upper() == 1.0e16 ?
std::numeric_limits<double>::infinity() : axis->Upper();
if (lower_limit > upper_limit) {
throw std::runtime_error(
"The lower limit must be lower (or equal) than the upper limit for "
"joint '" + joint_spec.Name() + "'.");
}

There also may be name remapping for ign* to gz* for things like math components.

@scpeters
Copy link
Contributor

I am working on this in the following branch:

@scpeters
Copy link
Contributor

I am working on this in the following branch:

I've opened a draft pull request in #17913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants