Timing issue setting floating property on undock

[stevel05]

If I set a listener on the dockedProperty and undock a dock by dragging it, and in the listener test the floatingProperty it is still set to false.

This causes a problem as I want to know if the undocked dock is actually floating or closed (as in not floating and not docked.).

If I check the floatingProperty in a runLater sub it has correctly changed to true

[RobertBColton]

Hrm, this definitely seems undesirable as I was actually going to rely on what you described in order to update DockFX for Java 9. I don't see yet why this is delayed, because as soon as the drag is detected on the title bar the dock node is set to floating:

DockFX/src/main/java/org/dockfx/DockTitleBar.java

Line 314 in 8d44134

dockNode.setFloating(true);

Which causes the floating property to be set to true:

DockFX/src/main/java/org/dockfx/DockNode.java

Line 285 in 8d44134

this.floatingProperty.set(floating);

[stevel05]

Possibly because in Docknode you are undocking (setting the dockedProperty) at line 246 and not setting the floatingProperty until line 285. Therefore the dockedProperty changelistener is being fired before the floating property is updated.

[RobertBColton]

Alright, I'll see if I can push a patch for it shortly without causing a regression. Thank you for finding that.

[stevel05]

Thanks very much, and not a problem

[RobertBColton]

While I'm going to be addressing this, I want to perhaps look at this another way. I think it may be confusing that I have both dockedProperty and floatingProperty which for the most part have the same meaning. When a node is undocked, it's essentially floating, and when it's floating, it's obviously not docked. There is an inbetween state where it can be neither, but for the purposes of DockFX, it's not useful to define that.

So considering this, would you be alright with me combining the docked and floating properties together into one? I would deprecate one and continue use of the other. I think that would make the API less confusing as well as fix this issue too.

[stevel05]

The only problem I could see then is that it would not be possible to tell if the dockpane was not visible (Closed).

[RobertBColton]

I believe the visible property should take care of that, right?

But now that you mentioned it, I believe I may want to change the behavior of close as well so that it does effect the visible property. As I have it now, I was only binding the close button to the visible property, but close itself should set it false, in case the dock node is closed by something other than the close button:

DockFX/src/main/java/org/dockfx/DockTitleBar.java

Line 101 in 8d44134

closeButton.visibleProperty().bind(dockNode.closableProperty());

So I will make these two changes then, I will be deprecating the floating property and changing close to always set visible to false.

[stevel05]

OK, sounds good to me.

[RobertBColton]

Alright, I've patched the issue: e66e091

To avoid breaking any existing users over something trivial, I simply decided to go with the first fix you suggested, to set the floating property before undocking.

I've also generated a new beta release with the fix:
https://github.com/RobertBColton/DockFX/releases/tag/0.3b

[stevel05]

Yes that got it, thanks.