-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Search ..." commands open an empty tab #621
Comments
Hi, it's working fine for me. Since when does this problem occur to you? Can you please try to reassign the command to your gesture, save your gesture and see if it works then? |
Hi and thank you for your answer. It started some days ago (maybe after one automatic update?). I tried everything (downgrade, inspect console, reassigning and so on) with no success. |
Ohh, so it's opening a completely empty tab without showing an empty search engine. I've experienced the problem too about 3 days ago on my working machine, but it only happened on one particular site and after a browser restart I wasn't able to reproduce it again. I've also checked the console and it was empty. Since downgrading Gesturefy doesn't fix the problem I assume it's some sort of bug in Firefox 94 which was released recently.
This however makes me think it's a bug in Gesturefy. Since I'm not able to reproduce it myself I rely on further investigation by you. Maybe you can detect some sort of pattern.
|
I made it, only messages are: |
Looks like this is an error from a different extension since Gesturefy's |
Yes, I tried in the past days to unable all the extensions that could be involved, but with no success. Besides, the fact that the first time the gesture works made me think it was a gesturefy extension bug, but I'll try to unable selectively by groups all the extensions to try to solve. I'll update you if I have news, thank you |
In theory another extension shouldn't be able to interfere with Gesturefy at least in this particular scenario. So it's probably not caused by another extension. Currently I'm able to reproduce the error on my working machine again but it only happens sometimes or on some websites. I really cannot make sense of it right now. |
Yes, it is the same for me, that is the reason I wrote to you ;) |
Just to be sure, you are using the "Search Text Selection In New Tab" right? Can you confirm that it does work if you disable tab focus/highlight?
Yea.. if you can confirm the above then this must be the case. |
Finally I solved! I made some esoteric research on my pc and the culprit is FISSION (site isolation) in firefox. The problem is present (with crazy results) when FISSION is enabled. I think firefox team has to work a little more on it. |
That's it, great catch! :) They just started rolling this out so it makes sense it doesn't happen on every machine. I'll open a ticket on bugzilla. |
;) |
Just for reference: https://bugzilla.mozilla.org/show_bug.cgi?id=1741694 |
Thank you |
I'm having same problem. |
For now this can only be "solved" by going to |
Wow, it started happening again. So I checked the |
Lucky enough to capture a log for this bug (when try to search some text with search popup menu)
Code when click it
|
@byzod Thanks for your investigation. However this is not related to the problem. You can also reproduce the problem with the simple "Search selected text" command. |
It's still happening. I only learned about this extension today, I'm total noob, and got startled by this bug. I guess I'm a bug-magnet =\ I can add few interesting findings. The most interesting one: when I open console tab to try and catch some error messages, the bug disappears completely and cannot be reproduced! I'm using "Search highlighted text in new tab" with focus switch to created tab. I can search text on any site any number of times with no issue. Also nothing is written to console. However, when I close console tab and try to search text again, bug returns! How this can be explained, I wonder? Honestly, I have no idea at all... One more observation - this bug only happens if I search selected text AND have "Switch to search tab" option enabled. If searching without focus shift, there is no bug. Also with custom URL in search field, but seems to not happen too... But "empty search disable" rule does not work in this case. Yea, its a mess! Though, I got lucky I found this issue, at least! I hope that switching off |
I've recently uptaded Firefox from 89.01 to 103 and later 104, and both newest versions cause that empty tab error. Sometimes it works, sometimes not. It was better on 103, cause there was some regularity in the occurrence of this problem. Every first using of popup particular search engine was opened empty tab, but if you used the same search engine again, you saw results of your searching in new tab. In 104 version problem became more often and unpredictable, so I was forced back to old 89.01 version, which doesn't cause any problems with popup searching. BTW, is it possible to add option to select individual search engines which show in pop-up window? |
I didn't notice differences among the >v100 versions; but occasionally, empty tabs appear, yes. @OLOPOLON regarding your "BTW" (select individual search engines): Currently, this is not possible due to Firefox' limited search API (and may never be), but have a look here: #584; you may use my suggested workaround by "outsourcing" search engines to bookmarks. |
Good news is that this bug is stable now, it might be helpful for debug I ALWAYS get a blank page, the search popup is unusable completely |
Indeed, I can confirm this. But since I'm unable to fix the bug please post any valuable information here: https://bugzilla.mozilla.org/show_bug.cgi?id=1741694 |
This addon has a working feature that you can select words and drag to search it with current search engine, looks similar. Hope it helps |
@byzod Thanks for the Info, looks like the developer added a timeout there as a workaround.
Edit: I tested it again and it seems like I crowed too soon. While it works at the beginning with few tabs, the problem reoccurs at a tab count of about 7 and more. |
Well it's there again :/ I can't reproduce it in a new profile, it's working normally. Only appears on my main profile and 100% blank page, however sometimes (like 15%) it's working if I disable all my other addon. Looks like problem related to performance and timeout or something... |
Can I have a timeout hack version of gesturefy as you mentioned please? @Robbendebiene
Since glitterdrag's drag search is 100% reliable for me while waiting Mozilla to fix this bug might take another 10 years... ;_; |
Extract the zip and then re-zip everything inside the |
Thank you so much, it works like a charm ❤️ Never expect 50 milliseconds would make such big difference, I love hacking And fuck Mozilla |
For me is impossible install, I get the error damaged file. |
All preset gestures are deleted. Rocker gesture will open a new blank tab search and sometimes it willl open a new tab with selected text. |
Hi! Using a gesture to search selected text in a new tab with option highlight the new tab open an empty tab. Same problem in the last few Gesturefy versions.
The text was updated successfully, but these errors were encountered: