Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre commit hook with husky #66

Open
Rishabh-malhotraa opened this issue Oct 8, 2021 · 4 comments · May be fixed by #69
Open

Add pre commit hook with husky #66

Rishabh-malhotraa opened this issue Oct 8, 2021 · 4 comments · May be fixed by #69
Assignees
Labels

Comments

@Rishabh-malhotraa
Copy link
Owner

I see inconsistency with formating in pull requests; to prevent this, it is better to configure a pre-commit hook to standardize formatting.

Resources

https://www.youtube.com/watch?v=oWty0Nw1ydk

https://khalilstemmler.com/blogs/tooling/enforcing-husky-precommit-hooks/

@pavankalyan-codes
Copy link
Contributor

Hey I can work on this. Could you pls assign this to me.

@pavankalyan-codes
Copy link
Contributor

Hey! raised PR for this #69 . Pls review and merge if everything looks fine on review.

@Rishabh-malhotraa
Copy link
Owner Author

Thanks for the PR @pavankalyan-codes , I'll review the changes in the coming days!

@Rishabh-malhotraa Rishabh-malhotraa linked a pull request Oct 16, 2021 that will close this issue
@hadviad0x15
Copy link

Hi sir, greeting of the day, I have worked in few react based projects. I have basic idea of how thing work around in react. I am taking part in hacktober fest 2021 and I found this issue interesting and think i can contribute to this. According to my understanding after reading the blog you suggest above I learn that here I have to make changes in package.json file and add a husky hook with have a pre commit, pre push also i need to make changes in scripts under package.json and add a prettier and eslint. This changes are need so when any developer try to save and commit it will automatically run prettier for formatting and eslint for coding convection. If i follow correctly please assign me this issue. @Rishabh-malhotraa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants