Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staking implementation improvements #24

Open
gabririgo opened this issue Sep 3, 2023 · 0 comments
Open

Staking implementation improvements #24

gabririgo opened this issue Sep 3, 2023 · 0 comments

Comments

@gabririgo
Copy link
Contributor

Summary

Implement some improvements on the staking system.

Motivation

The moveStake method does not allow moving from one pool to another in 1 single transaction, which it should. Requires staking implementation upgrade in the staking proxy. In the current staking system, a pool gets initialized in a specific epoch to participate to incentives, then is finalized at the end of the epoch. This requires two calls and all participating pools must be finalized before the 2nd next epoch. In order to save some gas, the logic could be amended.

Specification

  • query pool data from pool, do not initialize staking pool
  • claim reward during the epoch, without credit reward and later finalize
  • directly move stake from one pool to another (currently requires deactivating and reactivating in 1 batch transaction, will save some gas)

Rationale

Notes

There is reason why the staking system is designed as such, running every 2 weeks makes it manageable from a cost perspective, but worth investigating more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant