Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tool to check the usage of deprecated and unknown ESLint rules #187

Merged
merged 1 commit into from
Aug 20, 2024
Merged

New tool to check the usage of deprecated and unknown ESLint rules #187

merged 1 commit into from
Aug 20, 2024
+560 −3

Conversation

frantic1048
Copy link
Contributor

@frantic1048 frantic1048 commented Aug 9, 2024 •
edited
Loading

This PR resolves #185

Limitation:

  1. It currently only supports the legacy eslintrc config. We may extend support to flat config in the future.
  2. It currently only works with ESLint v8.

Misc:

  1. Renamed specs/eslint to specs/eslint-configs for better semantics.
  2. Used patched(merged, not released yet) fsWalk version that modified packages/fs/fs.walk/src/providers/stream.ts to address the issue with fsWalk's stream interface.

@frantic1048 frantic1048 added the enhancement New feature or request label Aug 9, 2024
@frantic1048 frantic1048 self-assigned this Aug 9, 2024
@frantic1048 frantic1048 force-pushed the feature/add-eslint-rule-linter branch 12 times, most recently from c9689ed to eecbf25 Compare August 13, 2024 09:14
@frantic1048 frantic1048 marked this pull request as ready for review August 13, 2024 09:19
@frantic1048 frantic1048 requested review from lixiaoyan and liby August 13, 2024 09:19
@frantic1048 frantic1048 force-pushed the feature/add-eslint-rule-linter branch 2 times, most recently from 6462f6e to 9a98024 Compare August 14, 2024 09:40
lixiaoyan
lixiaoyan requested changes Aug 14, 2024
View reviewed changes
@frantic1048 frantic1048 force-pushed the feature/add-eslint-rule-linter branch from 9a98024 to 0c5aaf6 Compare August 15, 2024 07:56
@frantic1048 frantic1048 requested a review from lixiaoyan August 15, 2024 07:59
@frantic1048 frantic1048 force-pushed the feature/add-eslint-rule-linter branch from 0c5aaf6 to 61d7599 Compare August 15, 2024 09:04
@frantic1048 frantic1048 requested a review from liby August 15, 2024 09:05
@frantic1048 frantic1048 force-pushed the feature/add-eslint-rule-linter branch 2 times, most recently from 79d4e4c to 72c7e1e Compare August 16, 2024 06:03
@frantic1048 frantic1048 force-pushed the feature/add-eslint-rule-linter branch from 72c7e1e to 5b5ab74 Compare August 16, 2024 06:05
@frantic1048 frantic1048 requested review from liby and lixiaoyan August 16, 2024 06:10
@frantic1048 frantic1048 force-pushed the feature/add-eslint-rule-linter branch from 5b5ab74 to 6f419a8 Compare August 19, 2024 07:34
@frantic1048 frantic1048 force-pushed the feature/add-eslint-rule-linter branch from 6f419a8 to 174d837 Compare August 19, 2024 09:53
@frantic1048 frantic1048 force-pushed the feature/add-eslint-rule-linter branch from 174d837 to 53a787f Compare August 20, 2024 01:57
lixiaoyan
lixiaoyan requested changes Aug 20, 2024
View reviewed changes
@frantic1048 frantic1048 force-pushed the feature/add-eslint-rule-linter branch from 53a787f to 92a97a6 Compare August 20, 2024 07:06
@frantic1048 frantic1048 requested a review from lixiaoyan August 20, 2024 07:06
@frantic1048 frantic1048 merged commit d187924 into main Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lixiaoyan lixiaoyan lixiaoyan approved these changes

@liby liby liby approved these changes

Assignees

@frantic1048 frantic1048

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A standalone tool to check the usage of deprecated and unknown ESLint rules
3 participants
@frantic1048 @lixiaoyan @liby