fix: Maximum call stack size exceeded (#40)

[milahu]

part of sveltejs/svelte#6716

start fixing #40 and sveltejs/svelte#4694

[Conduitry]

We don't want to be mutating Array.prototype to add our own new method there. This should either be implemented as a regular function that accepts the array as an argument, or it should use reassignments and concat.

[milahu]

This should either be implemented as a regular function that accepts the array as an argument

yepp

// original
a.push(...b, c)

// replaceMethod = "pushArray"
a.pushArray(b, [c])

// current version
// replaceMethod = "pushArrayNoMethod"
pushArray(a, b, [c])

or it should use reassignments and concat.

thats usually slower

code-red has no eslint, so the patched code looks a bit ugly

[benmccann]

could possibly tweak the naming a bit, but otherwise lgtm

[benmccann]

this should be this_array and other_list according to Rich's coding convention. though the variable name is perhaps a bit ambiguous - is it "another list" or a "list of other"? I might have the function signature be something like:

export function push_array(array, ...additional_arrays) {

[milahu]

otherList is a list of otherArray ... maybe call it otherArrayList?

example call:

push_array(thisArray, otherArray1, otherArray2, otherArray3)

[milahu]

closing for #71 - thanks all : )