Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create variant of GetEnergyBalanceForSpecies for auto-evo that just has the overall balance #5426

Open
hhyyrylainen opened this issue Aug 29, 2024 · 1 comment · May be fixed by #5780
Open

Comments

@hhyyrylainen
Copy link
Member

hhyyrylainen commented Aug 29, 2024

and doesn't try to track the individual consumptions and productions as calculating and storing those requires extra time which slows down auto-evo unnecessarily

This is mostly just copy-pasting but I'd like to see in any PR solving this some good architectural combining of the two method variants as much as possible to reduce real code duplication (but the more important consideration is raw performance, so some dirtyness here would be fine as this is a pretty well contained part that's critical for speed).

@hhyyrylainen hhyyrylainen added this to the Release 0.7.1 milestone Aug 29, 2024
@github-project-automation github-project-automation bot moved this to Backburner in Thrive Planning Aug 29, 2024
@0HyperCube 0HyperCube linked a pull request Dec 30, 2024 that will close this issue
4 tasks
@hhyyrylainen hhyyrylainen moved this from Backburner to In progress in Thrive Planning Jan 8, 2025
@hhyyrylainen hhyyrylainen moved this from In progress to Backburner in Thrive Planning Jan 13, 2025
@hhyyrylainen
Copy link
Member Author

There was a relatively complete implementation of this change here: #5780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backburner
Development

Successfully merging a pull request may close this issue.

2 participants