Downgrade Java version to 1.8 and set kotlin JVM target 1.8 to fix compilation issues in newer android studios #368
Conversation
android/build.gradle
Outdated
| sourceCompatibility JavaVersion.VERSION_17 | ||
| targetCompatibility JavaVersion.VERSION_17 | ||
| } | ||
| kotlinOptions { | ||
| jvmTarget = "17" |
There was a problem hiding this comment.
I see we were already using 17 from the targetCompatibility, but I think that might be too high? According to this table, Java 17 is only fully supported starting at Android 14.
I can never figure out where this might break, but my assumption is that if we accidentally use any newer API, it might compile to something incompatible on lower Android versions.
There was a problem hiding this comment.
That is a valid concern... I believe it might have been like this when the plugin was created and we forgot to downgrade it...
I haven't heard of any related issues, but still might be worth to downgrade it to be safe. I will do it as part of this PR.
There was a problem hiding this comment.
Downgraded and did some testing, seems to be working correctly. Lmk if you think this could have any unintended consequences @JayShortway!
There was a problem hiding this comment.
Nice, I think this is safer! I don't think there should be unintended consequences. (Famous last words 😅) Thanks for being thorough with testing! 🙏
tonidero
changed the title
Compiling the android app in newer android studios was failing because it was trying to use jvm 21, which isn't compatible. Additionally as @JayShortway, we were using a higher version of Java that we should. We were mostly ok, but this brings the levelt to the same as our native android SDK and other hybrids.