Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for string constants fix #27

Open
incebellipipo opened this issue May 1, 2020 · 1 comment
Open

Release for string constants fix #27

incebellipipo opened this issue May 1, 2020 · 1 comment

Comments

@incebellipipo
Copy link
Contributor

incebellipipo commented May 1, 2020

Hi all,

Is it possible to tag and release my tiny commit, 630ef17 ?

I forgot to mention for a need to release in my pr #21 .

I'm not sure new release is triggered by creating of new tag or PR to gennodejs-release repository.

If we release my commit, following operation will no longer be needed:

$ sed -i "/.*STATE_NEW:/c\  STATE_NEW: 'new'," /opt/ros/melodic/share/gennodejs/ros/multimaster_msgs_fkie/msg/MasterState.js &&\
  sed -i "/.*STATE_REMOVED:/c\  STATE_REMOVED: 'removed'," /opt/ros/melodic/share/gennodejs/ros/multimaster_msgs_fkie/msg/MasterState.js &&\
  sed -i "/.*STATE_CHANGED:/c\  STATE_CHANGED: 'changed'," /opt/ros/melodic/share/gennodejs/ros/multimaster_msgs_fkie/msg/MasterState.js

@chris-smith Is it possible?

@incebellipipo
Copy link
Contributor Author

@IanTheEngineer
Sorry to interrupt but, is it possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant