Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to glob@latest #32

Open
pierceray opened this issue Dec 10, 2018 · 1 comment
Open

Upgrade to glob@latest #32

pierceray opened this issue Dec 10, 2018 · 1 comment
Assignees
@jared-stilwell

Comments

@pierceray
Copy link
Contributor

We should update to a newer version of glob. When doing so there are a errors being reported when running the unit tests about not finding folders.
@jared-stilwell jared-stilwell self-assigned this Dec 11, 2018
@jared-stilwell
Copy link
Contributor

This seems to be introduced by v7.1.1 of node-glob. This seems related to the use of mock-fs in the unit tests. The most direct path to fixing this could be replacing the use of mock-fs with actual test fixture pantries that are managed under version control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jared-stilwell jared-stilwell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jared-stilwell @pierceray