Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review allow_sameorg.json #10

Closed
nodiscc opened this issue Nov 22, 2014 · 3 comments · Fixed by #11
Closed

Review allow_sameorg.json #10

nodiscc opened this issue Nov 22, 2014 · 3 comments · Fixed by #11
Assignees

Comments

@nodiscc
Copy link
Contributor

nodiscc commented Nov 22, 2014

Make sure that requests allowed by official-allow_sameorg.json are necessary for user-desirable functionality (eg. {"o":{"h":"*.youtube.com"},"d":{"h":"*.google.com"}}, may not be necessary, youtube.com is functional without requests to google.com)

@nodiscc nodiscc self-assigned this Nov 22, 2014
@myrdd
Copy link
Member

myrdd commented Nov 22, 2014

exactly. see also my comment #7 (comment)

@nodiscc
Copy link
Contributor Author

nodiscc commented Nov 30, 2014

Why not drop allow_sameorg alltogether? I think we should start with a "simple" Allow Functionality subscriptions list, described in #9.

After reviewing such a list, we might want to check individual origin/destinations pairs and move them to a new Allow Functionality only from same organization (which is what allow_sameorg should be called) if appropriate. But in the first time, having 2 lists to manage complexifies things. The allow-sameorg list will be incomplete because it takes a looong time to check every pair in allow-functionality (how do we check it? WHOIS data?).

So I'd like to start fresh with a single list.

@myrdd
Copy link
Member

myrdd commented Nov 30, 2014

That would be ok for me @nodiscc, but it might be more work if you split the json into two later (?).
However, subscriptions have way less priority than the code itself, at least that's my opinion.

whois data is an option, this probably needs to be investigated.

Please create an issue for each of the steps you're planning to do (or one issue with a task list).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants