Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to override auto-reload upon change to whitelist #656

Closed
jdgalt opened this issue May 21, 2015 · 8 comments
Closed

Add ability to override auto-reload upon change to whitelist #656

jdgalt opened this issue May 21, 2015 · 8 comments

Comments

@jdgalt
Copy link

jdgalt commented May 21, 2015

Where a web page references some currently-blocked outside site, I want to be allowed to enable that reference without causing a reload. This is important on sites like e-rewards.com where reloading a page causes what you were doing to be irreversibly lost.

@nodiscc
Copy link
Contributor

nodiscc commented May 21, 2015

@jdgalt you can disable autoreload on the preferences pages about:requestpolicy?basicprefs. Does it solve your problem?

@jdgalt
Copy link
Author

jdgalt commented May 21, 2015

It's a decent workaround, but I'd like to be able to do it on the fly.

@nodiscc
Copy link
Contributor

nodiscc commented May 21, 2015

ut I'd like to be able to do it on the fly.

How can it be done? A checkbox disable auto-reload in the menu?

@klemens
Copy link

klemens commented May 21, 2015

How can it be done?

Because the reload happens when the menu is closed, a button "Close without reload" would be enough.

@myrdd
Copy link
Member

myrdd commented May 21, 2015

a button "Close without reload" would be enough.

I doubt many people would use that button, but think some people will like it. Still, I wouldn't put that button in the menu by default. See #601 for a summary of proposed menu UI changes.

If RPC one day has the feature of customizing the menu, the "close without reload" button can definitely be part of it.

@nodiscc
Copy link
Contributor

nodiscc commented May 21, 2015

There is another workaround for this: open the menu, click the rule you'd like to modify (eg block all requests to *.crap-ad-site.com), then click the Preferences menu item. Your rule will register but the page won't reload. 100% not a hack

Still, I wouldn't put that button in the menu by default

Yes there's a risk of menu "bloat" (though this feature is useful), although most new switches/buttons could be made simple icons (no text, but with a tooltip), which would save space. Kinda like a toolbar inside the menu (would also work with the get more info about $domain button).

@myrdd
Copy link
Member

myrdd commented May 21, 2015

Another idea: closing the menu via clicking on the flag could mean "close without reload". What do you think? Would this work for you @jdgalt and @klemens?

Besides that, would you like a

although most new switches/buttons could be made simple icons (no text, but with a tooltip), which would save space

I agree. So there could be a simple icon for switching "auto-reload" on/off.

@jdgalt
Copy link
Author

jdgalt commented May 21, 2015

I'll try it nodiscc's way. Thanks!

@jdgalt jdgalt closed this as completed Jun 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants