-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display "Temporary" actions in italic + light green/red #517
Comments
@acrobat1 I personnally have no problem with the fonts, can you detail a bit more? Is the temporarily allow requests font too small for you? (by the way using bold fonts is not so great, it will cause the menu to grow larger, especially with long domain names/sites making lots of cross-site requests. Adding colors everywhere is also confusing.) |
Thank you for your quick reply:yes,partly the reason why I asked for this is that fonts are IMO a bit on the small side (but I reckon that also depends on monitor size,screen resolution and so on). |
I noticed about the same thing when watching people using RequestPolicy. People don't recognize the gray items as actionable. In my opinion:
@myrdd what do you think? This should be easy |
Principally I like the gray colour but I'm ok with changing it. I guess that black would be too dark. Personally I'd first try red and green colours for temp. rules, but lighter than for the permanent rules. Yellow could ce confused with the yellow flag of "Blocking Disabled". @nodiscc woul you like to try different font colours (and sizes perhaps) and propose some possibilities in form of screenshots? That would be great! Btw, the issue about font sizes is #329. @nodiscc please note that I'm planning to redesign the right pane a little as soon as the "strictness" feature can be supported. Currently the right pane in "deny & deny same domain" default mode is badly usable. |
This is ok. I also like the grey items but I've been testing RP along with a bunch of people and they nearly always get confused. Offsetting these items with 2 spaces at the beginning of the line would also be nice (so that users can see the temp allow action belongs to the same section/domain as the permanent allow action just above_ I'll try to add a few screenshots. I'd like to get a grasp of all UI/menu related issues first, to get an idea of how the menu will look like if all enhancements are added (subscriptions warning, filetype info, WOT integration, color changes...) |
That would be a very welcomed improvement,thanks for taking care of this. |
Great @nodiscc, looking forward :) |
As discussed in #482, temporary rules should also be in italic |
I think that the current gray characters for "Temporarily allow request" don't work very well for quickly eyeballing which temporary rules need to be allowed especially for sites making lots of cross-requests:maybe setting them in green just like the "Allow request" rules,but using italic/cursive fonts,at the same time putting the "Allow request" rules in bold could work?
Or maybe picking a different color altogether for Temporarily rules,like say yellow/italic could do even better?What do you think?
The text was updated successfully, but these errors were encountered: