Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heuristic option: unknown_sequences = (error|skip|as-is) #50

Open
yarikoptic opened this issue Mar 9, 2021 · 0 comments
Open

heuristic option: unknown_sequences = (error|skip|as-is) #50

yarikoptic opened this issue Mar 9, 2021 · 0 comments

Comments

@yarikoptic
Copy link
Member

In regards to

    if skipped_unknown:
        lgr.warning("Could not figure out where to stick %d sequences: %s" %
                    (len(skipped_unknown), skipped_unknown))

which is pretty much unknown_sequences="skip" for such an option, so we just skip those we cannot figure out ATM.
That could lead to a lengthy conversion which would still miss some critical data. so I think we should default to error and just make it easy to "overload" with a custom setting ....

until we come up with some centralized approach to heuristic options, it could be just

options = {
    'unknown_sequences': 'error'
}
for k, v in options.items():
     ek = 'REPROIN_' + k.upper()
     if ek in sys.environ:
          options[k] = sys.environ[ek]

thus allowing to override from environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant