Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit "intendedfor" annotation #38

Open
yarikoptic opened this issue Oct 19, 2019 · 3 comments
Open

Explicit "intendedfor" annotation #38

yarikoptic opened this issue Oct 19, 2019 · 3 comments

Comments

@yarikoptic
Copy link
Member

Absence of "IntendedFor" handling is a notable shortcoming. Recent issue within ReproIn about it was #36 (comment) by @dlevitas.

Although it might be possible to deduce it automagically (nipy/heudiconv#148 (comment)), and by default in case of a single fmap (or pair of se scans with differing _dir) to assign to all matching bold/dwi; I wonder if in ReproIn context we should better proceed with explicit convention. E.g. annotating both fmap and target scans with some _key-<index> (e.g. _fmap-1) to bind those together. With solutions for nipy/heudiconv#148 it would also be possible to verify that what was intended to be the fmap is compatible with the target scan.

ideas/feedback?

@satra
Copy link

satra commented Oct 23, 2019

sure, if there is an explicit match in named relation

annotating both fmap and target scans with some _key- (e.g. _fmap-1) to bind those together.

sounds reasonable. what happens for each of the different types of fmaps (pepolar, mag/phase, built in -such as pepolar diffusion scans)

@dlevitas
Copy link

I don't see anything pertaining to IntendedFor in the ReproIn code, so I'm assuming specifying a key to link fmap to corresponding func/dwi acquisitions wouldn't work at this point?

Not sure if this could also be lumped in with the heuristic-options

@yarikoptic
Copy link
Member Author

see my initial review within nipy/heudiconv#482 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants