Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome 44 support #122

Open
gjask opened this issue Apr 17, 2023 · 12 comments
Open

Gnome 44 support #122

gjask opened this issue Apr 17, 2023 · 12 comments

Comments

@gjask
Copy link

gjask commented Apr 17, 2023

Extension doesn't claim to have Gnome 44 support and rightly so. Currently overview gets broken if the extension is enabled on Gnome 44.

I understand developing this extension is not priority for you any-more but I'd like to at least know if you use it yourself and we can expect to get it fixed some time later on. Or if we should definitively move on and switch to different extension (or just get used to current Gnome overview). I know you previously encouraged your users to switch to V-Shell. But I still prefer your extension as its aesthetics feel more consistent with rest of Gnome.

@RensAlthuis
Copy link
Owner

I do still use it myself! I'll definitely update it to the new version when I have te time (so when I'm forced to basically)

@G-dH
Copy link

G-dH commented Apr 19, 2023

@gjask If you tell me exactly what you don't like about V-Shell, I'll fix the Vertical Overview for you ;)

@gjask
Copy link
Author

gjask commented Apr 19, 2023

@gjask If you tell me exactly what you don't like about V-Shell, I'll fix the Vertical Overview for you ;)

I have to say after few days I am slowly getting used to what I have considered to be rough edges at first, but that still doesn't make them disappear.

I've took two screenshots of overview on Fedora 38 with V-Shell enabled and disabled respectively while searching for an app. I'll try to explain some of my observations.

Snímek obrazovky z 2023-04-19 16-29-07
Snímek obrazovky z 2023-04-19 16-28-49

  1. I don't like two buttons added at start of dash. I have not found a way to disable them (may have missed that, I dunno).
  2. Inconsistent use of transparency and solid background. (Also inconsistent with the rest of Gnome Shell which doesn't seem to use transparency under text.)
  3. Dash has different style inconsistent with rest of the Gnome Shell.
  4. Missing padding in search field.

I guess you could say that I don't like it does change overview more than just in orientation and layout. It also changes style of its elements and thus breaks consistency with rest of Shell's UI.

@G-dH
Copy link

G-dH commented Apr 19, 2023

@gjask Thanks, I really appreciate your feedback.

  1. Buttons are optional, you can move each of them to the end or disable them on Appearance tab of the Settings window.
  2. V-Shell only reduces the background opacity of the search results, the dash background opacity is adjustable. You can also reduce the brightness of the wallpaper or disable it completely in the Settings window. Edit: actually I also added a bg color that is close to my default...
  3. Dash has reduced padding and spacing, background opacity and corner radius are optional. Nothing more.
  4. This happened because my Ubuntu has the padding too thick. I've already added some padding back, but I'll probably remove the custom padding entirely since it's OK by default on Fedora and nobody really cares but me.

Feel free to open an issue on my github with anything you don't like or miss about V-Shell.
Btw, the promised MR was already sent. From Prague :)

@gjask
Copy link
Author

gjask commented Apr 20, 2023

@G-dH Wow, you really did, thank you. I have tested it and it seems work great.

About feedback...

  1. I don't know how could I miss the button settings. You are right.
  2. I think main problem is Gnome Shell does display wallpaper in overview but does not in search results. So items on search view are not designed to be shown over wallpaper and may look silly (depending on wallpaper). I may be wrong again but as I understand V-Shell only can disable or enable wallpaper both at search view and overview at the same time.
  3. It also does stick to the edge, original does not. But it is a small difference.
  4. Nice.

After all I have to say, V-Shell is a really good extension. Thank you for your hard work. Also from Prague :D

@G-dH
Copy link

G-dH commented Apr 20, 2023

@gjask
2. You're right, the overview is designed for the gray background (not only search view), I'm still looking for some nice compromise. It's better to keep the overview wallpaper darker (adjustable in the Settings), then it seems good enough to me, and you can always disable the wallpaper in the overview completely.
3. I'll add an option

It's still a work in progress and any feedback is welcome. Thank you.

@crispinb
Copy link

One reason to continue using this extension is if a vertical overview is the only thing a user wants to change about Gnome. I'm pretty happy with Gnome defaults except for its lack of window management functionality. My preferred option for the latter is PaperWM, and vertical-overview happens to pair very nicely with it. Obviously our desires are not in any way your obligations! Just explaining why I for one am using this extension now.

Thus far I've found it's fine in Gnome 44, manually installed and with an edited metadata.json.

@G-dH
Copy link

G-dH commented Apr 27, 2023

@crispinb Thanks for the input, I'm ok with it, I'm just trying to get some feedback. @gjask actually helped me a lot with the design, now it's much better.

@hute37
Copy link

hute37 commented Apr 27, 2023

I think this is not much in scope with this awesome extension.

Try one of this extensions:

(maybe still not Gnome 44 compliant ...)

@LouHafer
Copy link

@G-dH, much as @crispinb, I like the minimally intrusive nature of vertical-overview. I'll keep an eye on v-shell, knowing that I'm living on borrowed time with vertical-overview. Thanks so much for that fix! Made my day when I found this thread.

@G-dH
Copy link

G-dH commented Apr 27, 2023

@LouHafer

I like the minimally intrusive nature of vertical-overview

V-Shell allows you to disable most of its features..

@suwalski
Copy link

suwalski commented May 1, 2023

@G-dH Wow, you really did, thank you. I have tested it and it seems work great.

@G-dH I have also tested your branch, and it works very well. I hope it gets merged and released. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants