Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T side utility for taking A site #49

Merged
merged 6 commits into from
Jan 26, 2025
Merged

Conversation

Friiiis
Copy link
Contributor

@Friiiis Friiiis commented Jan 25, 2025

Added T side utility for taking A site

  • Camera smoke (previously called "Ivy" in this repo)
  • Connector smoke from same spot as camera
  • Sandwich smoke
  • Backsite A molly from main
  • God flash A site

I suggest the camera and connector smokes from this PR replaces the ones already in this repo

Added T side utility for taking A site
- Camera smoke (previously called "Ivy" in this repo)
- Connector smoke from same spot as camera
- Sandwich smoke 
- Backsite A molly from main
- God flash A site

I suggest the camera and connector smokes from this PR replaces the ones already in this repo
@Friiiis Friiiis requested a review from ReneRebsdorf as a code owner January 25, 2025 19:36
@ReneRebsdorf
Copy link
Owner

This replaces the ivy and the connector smokes - I will update to match with the same annotation number and position in file.

tests report overlap, will look into this as well

@ReneRebsdorf ReneRebsdorf linked an issue Jan 26, 2025 that may be closed by this pull request
@ReneRebsdorf ReneRebsdorf marked this pull request as draft January 26, 2025 01:49
This updates the lineups graciously provided by @EstevaoCalera

These lineups should be a bit easier to "wedge into" and one of them has a better object to aim at (white spot instead of midpoint of two objects)
Copy link
Owner

@ReneRebsdorf ReneRebsdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary modifications made, LGTM.

@EstevaoCalera - fyi this updates two of your lineups. The 'gate' is now called 'camera' by popular convention (It seems?), and the lineups have been moved slightly to provide an easier ability to wedge into a corner, and with an 'object' to aim at, rather than aiming at the midpoint of two objects (for camera/gate smoke).

There was not much reason to update the connector smoke, except the new lineup is slightly faster due to being closer to spawn, and the above improvements, but a primary benefit was when moving the camera smoke, to keep them in the same position (like the previous ones were).

@ReneRebsdorf ReneRebsdorf marked this pull request as ready for review January 26, 2025 13:19
@ReneRebsdorf ReneRebsdorf merged commit 6ae89a4 into ReneRebsdorf:main Jan 26, 2025
1 check passed
@EstevaoCalera
Copy link
Contributor

@ReneRebsdorf I appreciate your effort to keep everything well explained. This repo is in development and it is awesome to know better alignments than mines. You are doing a pretty good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add train utility
3 participants