Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] More flexibility for which notifications are sent #36

Closed
rg9400 opened this issue May 4, 2022 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@rg9400
Copy link

rg9400 commented May 4, 2022

Right now, while you can choose which users to get notifications for, it will still send notifications in any event that PAL modifies languages/subs. This means that if it is watching for new episodes or file changes, any such event will trigger PAL which will then send a condensed notification that the episode was changed for all users. This isn't particularly useful and creates a lot of noise.

Ideally, there is a way to subscribe to only "active" triggers, e.g. plays or I guess any activity if so configured for the user. I would also want notifications for changes made during the scheduled run if enabled, but you could bifurcate those out if you want more flexibility as well. But from my usecase, the main goal is to suppress the new episode/file change notifications

Thanks!

@RemiRigal RemiRigal added the enhancement New feature or request label May 4, 2022
@RemiRigal
Copy link
Owner

Implemented in #37, see the PR or the README for more details about the implementation and how to use it.

The changes have been merged and released in version v1.1.1. Let me know if it fits your needs !

@rg9400
Copy link
Author

rg9400 commented May 6, 2022

This is working, thanks a ton! Closing the issue

@rg9400 rg9400 closed this as completed May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants