Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CoffeeScript to JS #456

Closed
mi-wood opened this issue Feb 16, 2018 · 3 comments
Closed

Convert CoffeeScript to JS #456

mi-wood opened this issue Feb 16, 2018 · 3 comments

Comments

@mi-wood
Copy link
Member

mi-wood commented Feb 16, 2018

It's probably time we solidify around just using JS. CoffeeScript is not a common language to use and it doesn't make sense to have two scripting languages at once (the map views use js for example)

I found https://decaffeinate-project.org/, which probably get's a lot of the easy stuff done, but will require finding what bugs that produces and patching them.

@stardust66
Copy link
Contributor

I just tried out decaffeinate, and it works, except that it uses ES6, which Phantomjs and older browsers don't support. It's in the "assumptions" section of their conversion guide.

ariya/phantomjs#15287

Introducing ECMA will require nearly-complete rewrite and - keeping in m8ind I seem to be the only active dev of PJS now - will need to wait till other - more urgent - issues are solved.

What do you think about adding Babel so we can use decaffeinate and write more modern javascript while still having tests pass?

@mi-wood
Copy link
Member Author

mi-wood commented Feb 16, 2018

@stardust66 thanks for getting started on this! I would say go ahead and use babel if that's what you think is best. going to defer to your judgement since you've been working with the js the most

@tkwidmer
Copy link
Contributor

tkwidmer commented Mar 5, 2018

i'm in favor of introducing ES6. This allows us to maybe eventually decouple the two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants