Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some pages aren't translation-ready #419

Closed
DeeDeeG opened this issue Jan 11, 2018 · 1 comment
Closed

Some pages aren't translation-ready #419

DeeDeeG opened this issue Jan 11, 2018 · 1 comment

Comments

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Jan 11, 2018

From #413:

When looking at @stardust66's PR over at Intimaria/refugerestrooms:#1, I noticed that we have some pages that aren't translation-ready.

We need to update:

  • the "splash" page (homepage),
  • the Contact page,
  • the search results page,
  • the nav bar (at the top)
  • the footer
  • search bar buttons
  • ARIA labels (probably)
  • and if somehow possible, the API documentation page.

Making them "translation-ready" would involve taking "hard-coded" sentences and phrases and moving them into a [something].en.yaml file, then updating the actual pages to refer to translation strings in place of hard-coded phrases. In other words, expand the existing translation system to also cover the pages I mentioned.

Solving this helps us to progress with #396 and ensure we can more-comprehensively complete #413

@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Feb 22, 2018

The API documentation page still isn't translated, since all the text for that is hard-coded into a javascript file.

And looking forward, if we add new text to the app, said text should use the i18n API.

But this is basically done, so I'm closing this! Woo!

@DeeDeeG DeeDeeG closed this as completed Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant