From d85311dac2b90af00c7410c19c88984ed5efd31d Mon Sep 17 00:00:00 2001 From: Sarin Udompanish Date: Tue, 25 Apr 2023 14:42:15 +0700 Subject: [PATCH 1/5] feat: remove font bold --- packages/halo-theme/src/fonts.less | 9 --------- 1 file changed, 9 deletions(-) diff --git a/packages/halo-theme/src/fonts.less b/packages/halo-theme/src/fonts.less index 506c5dd2e2..30254283d3 100644 --- a/packages/halo-theme/src/fonts.less +++ b/packages/halo-theme/src/fonts.less @@ -15,12 +15,3 @@ src: url('https://cdn.refinitiv.net/public/libs/elf/assets/elf-theme-halo/resources/fonts/proximanovafin/proximanovafin-semibold.woff2') format('woff2'), url('https://cdn.refinitiv.net/public/libs/elf/assets/elf-theme-halo/resources/fonts/proximanovafin/proximanovafin-semibold.woff') format('woff'); } - -@font-face { - font-family: 'Proxima Nova Fin'; - font-style: normal; - font-weight: 700; - font-display: swap; - src: url('https://cdn.refinitiv.net/public/libs/elf/assets/elf-theme-halo/resources/fonts/proximanovafin/proximanovafin-bold.woff2') format('woff2'), - url('https://cdn.refinitiv.net/public/libs/elf/assets/elf-theme-halo/resources/fonts/proximanovafin/proximanovafin-bold.woff') format('woff'); -} \ No newline at end of file From 7e9894bdd08aa4007d3f547b61fa0c07072bdda3 Mon Sep 17 00:00:00 2001 From: wsuwt Date: Wed, 26 Apr 2023 14:10:19 +0700 Subject: [PATCH 2/5] fix: native header element font-weight --- packages/halo-theme/src/native-elements/h4.less | 2 +- packages/halo-theme/src/native-elements/h5.less | 2 +- packages/halo-theme/src/native-elements/h6.less | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/halo-theme/src/native-elements/h4.less b/packages/halo-theme/src/native-elements/h4.less index 0bd999cbb5..2a406124c9 100644 --- a/packages/halo-theme/src/native-elements/h4.less +++ b/packages/halo-theme/src/native-elements/h4.less @@ -4,6 +4,6 @@ h4 { font-size: 24px; margin-bottom: 10px; text-transform: uppercase; - font-weight: bold; + font-weight: 600; line-height: calc(30/24); } diff --git a/packages/halo-theme/src/native-elements/h5.less b/packages/halo-theme/src/native-elements/h5.less index 924dd52842..df827a3925 100644 --- a/packages/halo-theme/src/native-elements/h5.less +++ b/packages/halo-theme/src/native-elements/h5.less @@ -4,6 +4,6 @@ h5 { font-size: 18px; margin-bottom: 10px; text-transform: uppercase; - font-weight: bold; + font-weight: 600; line-height: calc(24/18); } diff --git a/packages/halo-theme/src/native-elements/h6.less b/packages/halo-theme/src/native-elements/h6.less index e21c538b95..cfc2689134 100644 --- a/packages/halo-theme/src/native-elements/h6.less +++ b/packages/halo-theme/src/native-elements/h6.less @@ -4,6 +4,6 @@ h6 { font-size: 16px; margin-bottom: 10px; text-transform: uppercase; - font-weight: bold; + font-weight: 600; line-height: calc(22/16); } From 8df770fccdecdd27e2d57ee1b8ad10f3905da759 Mon Sep 17 00:00:00 2001 From: wsuwt Date: Wed, 26 Apr 2023 14:10:34 +0700 Subject: [PATCH 3/5] docs: fix font-weight in demo pages --- packages/elements/src/heatmap/__demo__/color.html | 2 +- .../elements/src/heatmap/__demo__/custom-cell.html | 2 +- packages/elements/src/heatmap/__demo__/event.html | 12 ++++++------ packages/elements/src/heatmap/__demo__/index.html | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/elements/src/heatmap/__demo__/color.html b/packages/elements/src/heatmap/__demo__/color.html index 5dbcaa47c0..d795698d7a 100644 --- a/packages/elements/src/heatmap/__demo__/color.html +++ b/packages/elements/src/heatmap/__demo__/color.html @@ -108,7 +108,7 @@

EF Heatmap - Colors

el.tooltipCallback = function (cell) { var tooltip = document.createElement('div'); var template = ` -
Actual value:
+
Actual value:
${cell.value}
`; diff --git a/packages/elements/src/heatmap/__demo__/custom-cell.html b/packages/elements/src/heatmap/__demo__/custom-cell.html index eea8cdc756..2d6c833979 100644 --- a/packages/elements/src/heatmap/__demo__/custom-cell.html +++ b/packages/elements/src/heatmap/__demo__/custom-cell.html @@ -99,7 +99,7 @@

EF Heatmap - Custom cell

el.tooltipCallback = function (cell) { var tooltip = document.createElement('div'); var template = ` -
Actual value:
+
Actual value:
${cell.value}
`; diff --git a/packages/elements/src/heatmap/__demo__/event.html b/packages/elements/src/heatmap/__demo__/event.html index 3995523ef8..6612fddccd 100644 --- a/packages/elements/src/heatmap/__demo__/event.html +++ b/packages/elements/src/heatmap/__demo__/event.html @@ -51,7 +51,7 @@

Sapphire Heatmap

- + @@ -64,14 +64,14 @@

Sapphire Heatmap

Menu 1 Menu 2 - Show Cell Data + Show Cell Data - - - \ No newline at end of file + diff --git a/packages/elements/src/heatmap/__demo__/index.html b/packages/elements/src/heatmap/__demo__/index.html index 3d4a89fb67..12dd824b45 100644 --- a/packages/elements/src/heatmap/__demo__/index.html +++ b/packages/elements/src/heatmap/__demo__/index.html @@ -96,7 +96,7 @@

EF Heatmap

el.tooltipCallback = function (cell) { var tooltip = document.createElement('div'); var template = ` -
Actual value:
+
Actual value:
${cell.value}
`; From 459e8208510c142ba4015ce6901ebf3b5d9ad6d6 Mon Sep 17 00:00:00 2001 From: wsuwt Date: Wed, 26 Apr 2023 15:16:51 +0700 Subject: [PATCH 4/5] chore: update LICENSE removing `bold` font reference --- LICENSE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/LICENSE.md b/LICENSE.md index 342becbd93..58d66f10a2 100644 --- a/LICENSE.md +++ b/LICENSE.md @@ -5,4 +5,4 @@ License details can be found in the `LICENSE` file. It's available in each packa >The font "Proxima Nova Fin" shall only be used within Refinitiv products or services. The copyright owner must approve any use of such font outside of Refinitiv products or services, which may be subject to a fee. Please see https://www.fontspring.com/lic/fontspring/webfont#license_text > ->Font styles in Halo theme are only Regular, Semi Bold and Bold. Do not use 'Italic' style due to the license on Proxima Nova Fin font. +>Do not use 'Italic' style due to the license on Proxima Nova Fin font. From 7b54b14eb634d31481c7163874fa65903670a288 Mon Sep 17 00:00:00 2001 From: Sarin-Udompanish Date: Fri, 28 Apr 2023 13:30:47 +0700 Subject: [PATCH 5/5] fix: remove font bold from elements --- documents/src/pages/elements/heatmap.md | 4 ++-- documents/src/pages/elements/tooltip.md | 4 ++-- documents/src/pages/styles/typography.md | 13 ++----------- packages/demo-block/src/demo-block.ts | 2 +- .../src/custom-elements/ef-tornado-item.less | 11 +++++++++++ 5 files changed, 18 insertions(+), 16 deletions(-) diff --git a/documents/src/pages/elements/heatmap.md b/documents/src/pages/elements/heatmap.md index 2c4a891807..1f4f1feef4 100644 --- a/documents/src/pages/elements/heatmap.md +++ b/documents/src/pages/elements/heatmap.md @@ -408,7 +408,7 @@ const generateData = (r, c) => { el.tooltipCallback = (cell) => { const tooltip = document.createElement('div'); - const template = "
Actual value:
" + cell.value + "
"; + const template = "
Actual value:
" + cell.value + "
"; tooltip.innerHTML = template; return tooltip; }; @@ -435,7 +435,7 @@ const el = document.querySelector("ef-heatmap"); el.tooltipCallback = (cell) => { const tooltip = document.createElement("div"); const template = ` -
Actual value:
+
Actual value:
${cell.value}
`; tooltip.innerHTML = template; diff --git a/documents/src/pages/elements/tooltip.md b/documents/src/pages/elements/tooltip.md index 7e2501e2b6..3293884c3c 100644 --- a/documents/src/pages/elements/tooltip.md +++ b/documents/src/pages/elements/tooltip.md @@ -254,7 +254,7 @@ const tooltip = document.getElementById('symbol-tooltip'); tooltip.renderer = (target) => { const ret = document.createElement('div'); const title = document.createElement('div'); - title.style.fontWeight = 'bold'; + title.style.fontWeight = '600'; title.style.paddingBottom = '3px'; const price = document.createElement('div'); ret.appendChild(title); @@ -310,7 +310,7 @@ const tooltip = document.getElementById('symbol-tooltip'); tooltip.renderer = (target) => { const ret = document.createElement('div'); const title = document.createElement('div'); - title.style.fontWeight = 'bold'; + title.style.fontWeight = '600'; title.style.paddingBottom = '3px'; const price = document.createElement('div'); ret.appendChild(title); diff --git a/documents/src/pages/styles/typography.md b/documents/src/pages/styles/typography.md index ab205ec706..7c0754037b 100755 --- a/documents/src/pages/styles/typography.md +++ b/documents/src/pages/styles/typography.md @@ -11,16 +11,13 @@ In accordance with Refinitiv's Halo Design System, the default font in your appl *>The font "Proxima Nova Fin" shall only be used within Refinitiv products or services. The copyright owner must approve any use of such font outside of Refinitiv products or services, which may be subject to a fee. Please see https://www.fontspring.com/lic/fontspring/webfont#license_text -x> Font styles in Halo theme are only Regular, Semi Bold and Bold. Do not use 'Italic' style due to the license on Proxima Nova Fin font. +x> Font styles in Halo theme are only Regular and Semi Bold. Do not use 'Italic' style due to the license on Proxima Nova Fin font. :: ```css .semibold { font-weight: 500; } -.bold { - font-weight: 600; -} .fonts { font-size: 24px; } @@ -32,18 +29,12 @@ A B C D E F G H I J K L M N O P Q R S T U V W X Y Z a b c d e f g h i j k l m n o p q r s t u v w x y z 0 1 2 3 4 5 6 7 8 9 -
Proxima Nova Fin Semibold (500)
+
Proxima Nova Fin Semibold (500, 600)
A B C D E F G H I J K L M N O P Q R S T U V W X Y Z a b c d e f g h i j k l m n o p q r s t u v w x y z 0 1 2 3 4 5 6 7 8 9
-
Proxima Nova Fin Bold (600)
-
-A B C D E F G H I J K L M N O P Q R S T U V W X Y Z -a b c d e f g h i j k l m n o p q r s t u v w x y z -0 1 2 3 4 5 6 7 8 9 -
``` ```javascript import { halo } from '/theme-loader.js'; diff --git a/packages/demo-block/src/demo-block.ts b/packages/demo-block/src/demo-block.ts index 521f83cba9..d6a7286a6e 100644 --- a/packages/demo-block/src/demo-block.ts +++ b/packages/demo-block/src/demo-block.ts @@ -106,7 +106,7 @@ themeLabel.style.fontSize = '15px'; themeLabel.style.left = '10px'; themeLabel.style.top = '10px'; themeLabel.style.padding = '2px 4px'; -themeLabel.style.fontWeight = 'bold'; +themeLabel.style.fontWeight = '600'; themeLabel.style.textTransform = 'uppercase'; themeLabel.innerHTML = removePrefixName(currentTheme); diff --git a/packages/halo-theme/src/custom-elements/ef-tornado-item.less b/packages/halo-theme/src/custom-elements/ef-tornado-item.less index db11b6a540..46ff59cfa0 100644 --- a/packages/halo-theme/src/custom-elements/ef-tornado-item.less +++ b/packages/halo-theme/src/custom-elements/ef-tornado-item.less @@ -1 +1,12 @@ @import '@refinitiv-ui/elemental-theme/src/custom-elements/ef-tornado-item'; + +:host { + &[highlighted] { + [part=label], + [part=primary-bar], + [part=secondary-bar] { + font-weight: 600; + } + } +} +