-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(select): improve screen reader support #80
Conversation
b0cfb1d
to
ddd5354
Compare
ddd5354
to
b517c8e
Compare
I tested with the following tools on Windows and get result below.
Note: Test on Chrome. |
packages/elements/src/select/__test__/select.accessibility.test.js
Outdated
Show resolved
Hide resolved
Actually, the problem occur when we put |
You need to press |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Please see my comment to not forget to update accessibility docs.
Description
Improves screen reader support for
select
.#74 must be merge before merging this pull request.
Type of change
Please delete options that are not relevant.
Checklist