-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove z-index from collapse #682
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
Size Change: -22 B (0%) Total Size: 1.56 MB
ℹ️ View Unchanged
|
wsuwt
changed the title
Remove zindex from collapse
collapse: remove z-index from collapse
May 10, 2023
wsuwt
changed the title
collapse: remove z-index from collapse
fix: remove z-index from collapse
May 10, 2023
Sarin-Udompanish
previously approved these changes
May 12, 2023
Sarin-Udompanish
approved these changes
May 15, 2023
Kudos, SonarCloud Quality Gate passed! |
wsuwt
added a commit
that referenced
this pull request
May 24, 2023
* docs: fix to use correct lang code on japanese sample on Langauges Support page (#689) * refactor: group functions that returns same value (#674) * refactor: replace `ifDefined` with `nothing`, a more consistent falsy value (#673) * fix: remove `z-index` from collapse implementation (#682) * fix: remove z-index from collapse header * refactor: replace `ifdefined` with `nothing` * fix: add event listener to ef-header instead * test: update test cases according to DOM change * docs: fix aria-level typo * docs: reverts demo page * refactor: use nullish coalescing operator * fix: remove duplicate `nothing` * refactor: rename TooltipPositionMap variable to avoid clashing it with imported type (#677) Co-authored-by: Sakchai Homhual <[email protected]> * refactor: default parameter should be the last one (#676) * refactor: default parameter should be the last one * refactor: move optional param in `selectPart()` to be the last --------- Co-authored-by: Sakchai Homhual <[email protected]> * refactor: remove legacy event property, `event.keyCode` (#675) * refactor: remove legacy Enter keyCode * fix: add keyboard support for IE11 * refactor: remove `keyCode` * test: remove legacy test * docs: update typograpy page (#690) * refactor: use optional chaining instead (#699) * refactor: use optional chaining instead * refactor: use null coalescing operator * refactor: replace ternary operator with `if-else` statement (#701) * refactor: replace ternary operator with `if-else` statement * refactor: remove redundant assignment * fix: update `line-height` to match Halo specification (#697) * fix: line-height to match specs * docs: use normal line-height for demo-block buttons * refactor: extract nested ternary operator (#700) * refactor: extract nested ternary operator * refactor: remove brackets * chore: update dependencies (#706) * chore(release): publish [skip ci] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] * Merge branch 'v7' into Syncs-v6-to-v7 * test: update collapse snapshots * chore: fix `nx` version --------- Co-authored-by: Domrongpon Tanpaibul <[email protected]> Co-authored-by: Sakchai Homhual <[email protected]> Co-authored-by: refinitiv-ui-dev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
z-index
from collapse header to avoid it clashing withoverlay
implementation. Its behaviour should remain the same. Previously, it's been added as part of a11y implementation last year.ef-header
z-indez
usage that causes overlay overlapping issuestopPropagation()
header-toggle
toheader-label
to reflect the changecursor: pointer
CSS to elemental theme as it is cleaner and more consistentFixes STG-417
Type of change
Please delete options that are not relevant.
Checklist