-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(calendar): unexpected blur
event fired when view changes
#655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
Size Change: +99 B (0%) Total Size: 1.56 MB
ℹ️ View Unchanged
|
bualoy-napat
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me
Kudos, SonarCloud Quality Gate passed! |
wsuwt
added a commit
that referenced
this pull request
May 1, 2023
* test: increase mocha test timeout to 5 sec (#642) * refactor(combo-box): use conditional template rendering instead of `hidden` attribute to hide clear icon (#602) * fix(calendar): unexpected `blur` event fired when view changes (#655) * chore(release): publish [skip ci] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] --------- Co-authored-by: wattachai <[email protected]> Co-authored-by: Wasuwat Limsuparhat <[email protected]> Co-authored-by: refinitiv-ui-dev <[email protected]> Co-authored-by: Sarin Udompanish <[email protected]>
Theeraphat-Sorasetsakul
added a commit
that referenced
this pull request
May 17, 2023
* test: increase mocha test timeout to 5 sec (#642) * refactor(combo-box): use conditional template rendering instead of `hidden` attribute to hide clear icon (#602) * fix(calendar): unexpected `blur` event fired when view changes (#655) * chore(release): publish [skip ci] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] * docs: fix wrong item type of multiple list demo (#666) * fix: add checkbox theme to item element to made it render on multiple mode * fix: revert import checkbox theme * docs: fix wrong item type of multiple list demo * docs: fix generated `tree-item` type in demo page --------- Co-authored-by: Sarin Udompanish <[email protected]> Co-authored-by: wsuwt <[email protected]> * chore(deps): bump yaml from 2.2.1 to 2.2.2 (#664) Bumps [yaml](https://github.com/eemeli/yaml) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/eemeli/yaml/releases) - [Commits](eemeli/yaml@v2.2.1...v2.2.2) --- updated-dependencies: - dependency-name: yaml dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wasuwat Limsuparhat <[email protected]> * docs: notify user to reload page after switch theme (#670) * docs: notify user to reload page after switch theme * Update documents/src/pages/build-app/theme-switching.md Co-authored-by: Wasuwat Limsuparhat <[email protected]> --------- Co-authored-by: Wasuwat Limsuparhat <[email protected]> * chore: add black duck workflow (#667) * feat: remove font bold (#665) * feat: remove font bold * fix: native header element font-weight * docs: fix font-weight in demo pages * chore: update LICENSE removing `bold` font reference * fix: remove font bold from elements --------- Co-authored-by: Sarin Udompanish <[email protected]> Co-authored-by: wsuwt <[email protected]> Co-authored-by: Wasuwat Limsuparhat <[email protected]> * feat: export `nothing` value from `lit` (#671) * chore(release): publish [skip ci] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] * docs: add file extension to dynamic import of theme switching example (#683) * test: convert resize observer loop error to warning (#679) * feat(test-helper): add mocha util converting resize observer loop error to warning * test(canvas): apply observer loop handler * test(clock): apply observer loop handler * test(heatmap): apply observer loop handler * test(interactive-chart): apply observer loop handler * test(layout): apply observer loop handler * test(notification): apply observer loop handler * test(overlay): apply observer loop handler * test(sparkline): apply observer loop handler * test(swing-gauge): apply observer loop handler * test(tornado-chart): apply observer loop handler * test(test-helpers): add test for resize observer loop handler * refactor(test-helpers): refactor resize observer loop handler to test helper's side effect * test(elements): remove resize observer loop handler import * refactor(test-helpers): cleanup export * refactor(test-helpers): fix code smell --------- Co-authored-by: Wasuwat Limsuparhat <[email protected]> * fix: responsive element not work in ios 15 and below (#680) Co-authored-by: wattachai <[email protected]> * chore(release): publish [skip ci] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] * test: fix to using web/test-runner syntax * test: fix ignore coverage syntax * chore: replace web dev server with vite (#681) * chore: update demo page * chore: remove all web-dev-server config and update demo * chore: add missing demo css file to heatmap demo * chore: remove native button demo * chore: change ignore eslint in demo block * chore: remove visibility hidden from demo block --------- Co-authored-by: Sarin-Udompanish <[email protected]> * refactor: chart bare entry PR * test: update chart snapshot * docs(chart): revert Type back to support jsdoc --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: wattachai <[email protected]> Co-authored-by: refinitiv-ui-dev <[email protected]> Co-authored-by: Sarin-Udompanish <[email protected]> Co-authored-by: Sarin Udompanish <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Napat Bualoy <[email protected]> Co-authored-by: Theeraphat Sorasetsakul <[email protected]> Co-authored-by: Theeraphat-Sorasetsakul <[email protected]>
Theeraphat-Sorasetsakul
added a commit
that referenced
this pull request
May 22, 2023
* feat(chart): create bare entrypoint to reduce bundle size * refactor(chart): update canvas pointer to using ref * chore(chart): unregister chartjs features to be bare * refactor(chart): chart bare entry PR (#691) * test: increase mocha test timeout to 5 sec (#642) * refactor(combo-box): use conditional template rendering instead of `hidden` attribute to hide clear icon (#602) * fix(calendar): unexpected `blur` event fired when view changes (#655) * chore(release): publish [skip ci] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] * docs: fix wrong item type of multiple list demo (#666) * fix: add checkbox theme to item element to made it render on multiple mode * fix: revert import checkbox theme * docs: fix wrong item type of multiple list demo * docs: fix generated `tree-item` type in demo page --------- Co-authored-by: Sarin Udompanish <[email protected]> Co-authored-by: wsuwt <[email protected]> * chore(deps): bump yaml from 2.2.1 to 2.2.2 (#664) Bumps [yaml](https://github.com/eemeli/yaml) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/eemeli/yaml/releases) - [Commits](eemeli/yaml@v2.2.1...v2.2.2) --- updated-dependencies: - dependency-name: yaml dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wasuwat Limsuparhat <[email protected]> * docs: notify user to reload page after switch theme (#670) * docs: notify user to reload page after switch theme * Update documents/src/pages/build-app/theme-switching.md Co-authored-by: Wasuwat Limsuparhat <[email protected]> --------- Co-authored-by: Wasuwat Limsuparhat <[email protected]> * chore: add black duck workflow (#667) * feat: remove font bold (#665) * feat: remove font bold * fix: native header element font-weight * docs: fix font-weight in demo pages * chore: update LICENSE removing `bold` font reference * fix: remove font bold from elements --------- Co-authored-by: Sarin Udompanish <[email protected]> Co-authored-by: wsuwt <[email protected]> Co-authored-by: Wasuwat Limsuparhat <[email protected]> * feat: export `nothing` value from `lit` (#671) * chore(release): publish [skip ci] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] * docs: add file extension to dynamic import of theme switching example (#683) * test: convert resize observer loop error to warning (#679) * feat(test-helper): add mocha util converting resize observer loop error to warning * test(canvas): apply observer loop handler * test(clock): apply observer loop handler * test(heatmap): apply observer loop handler * test(interactive-chart): apply observer loop handler * test(layout): apply observer loop handler * test(notification): apply observer loop handler * test(overlay): apply observer loop handler * test(sparkline): apply observer loop handler * test(swing-gauge): apply observer loop handler * test(tornado-chart): apply observer loop handler * test(test-helpers): add test for resize observer loop handler * refactor(test-helpers): refactor resize observer loop handler to test helper's side effect * test(elements): remove resize observer loop handler import * refactor(test-helpers): cleanup export * refactor(test-helpers): fix code smell --------- Co-authored-by: Wasuwat Limsuparhat <[email protected]> * fix: responsive element not work in ios 15 and below (#680) Co-authored-by: wattachai <[email protected]> * chore(release): publish [skip ci] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] - @refinitiv-ui/[email protected] * test: fix to using web/test-runner syntax * test: fix ignore coverage syntax * chore: replace web dev server with vite (#681) * chore: update demo page * chore: remove all web-dev-server config and update demo * chore: add missing demo css file to heatmap demo * chore: remove native button demo * chore: change ignore eslint in demo block * chore: remove visibility hidden from demo block --------- Co-authored-by: Sarin-Udompanish <[email protected]> * refactor: chart bare entry PR * test: update chart snapshot * docs(chart): revert Type back to support jsdoc --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: wattachai <[email protected]> Co-authored-by: refinitiv-ui-dev <[email protected]> Co-authored-by: Sarin-Udompanish <[email protected]> Co-authored-by: Sarin Udompanish <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Napat Bualoy <[email protected]> Co-authored-by: Theeraphat Sorasetsakul <[email protected]> Co-authored-by: Theeraphat-Sorasetsakul <[email protected]> * refactor(chart): restructure file to make it cleaner * docs(chart): rewrite to make it understandable * docs(chart): remove unwanted line break * docs(chart): add missing comma * Update packages/elements/src/chart/elements/chart.ts Co-authored-by: Wasuwat Limsuparhat <[email protected]> * Update packages/elements/src/chart/elements/chart.ts Co-authored-by: Wasuwat Limsuparhat <[email protected]> * docs(chart): remove TODO comment * Update packages/elements/src/chart/elements/chart.ts Co-authored-by: Wasuwat Limsuparhat <[email protected]> * Update packages/elements/src/chart/plugins/index.ts Co-authored-by: wattachai <[email protected]> * docs(chart): revise reduce bundle size section * refactor(chart): fix export way * docs(chart): add more examples * fix(chart): prevent vulnerable code * docs(chart): fix wording to be readable * fix(chart): fix regex to be vulnerable --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Wasuwat Limsuparhat <[email protected]> Co-authored-by: wattachai <[email protected]> Co-authored-by: refinitiv-ui-dev <[email protected]> Co-authored-by: Sarin-Udompanish <[email protected]> Co-authored-by: Sarin Udompanish <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Napat Bualoy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unexpected
blur
event fired when view changesFixes https://jira.refinitiv.com/browse/STG-397
Solution
Keeping focus at view change button while
willUpdate
lifecycle.Type of change
Please delete options that are not relevant.
Checklist