Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi-input): only focus input on click clear button #64

Conversation

Sarin-Udompanish
Copy link
Collaborator

Description

Element should not be focused when removing item programmatically

Fixes # (issue)
ELF-1628

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@Sarin-Udompanish Sarin-Udompanish force-pushed the fix/multi-input-should-not-be-focused-when-removing-item-programmatically branch from ce9f6fd to ca74d73 Compare November 3, 2021 07:14
@Sarin-Udompanish Sarin-Udompanish changed the title fix: only focus input on click clear button fix(multi-input): only focus input on click clear button Nov 3, 2021
Copy link
Collaborator

@Theeraphat-Sorasetsakul Theeraphat-Sorasetsakul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good for all browsers. This can be merged.

@Sarin-Udompanish Sarin-Udompanish merged commit 214452a into develop Nov 4, 2021
@Sarin-Udompanish Sarin-Udompanish deleted the fix/multi-input-should-not-be-focused-when-removing-item-programmatically branch November 4, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants