-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(card): Card can not expand nested overlay-menu in touch devices #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nantawat-Poothong
changed the title
fix(card): card not expand nested overlay-menu in touch devices
fix(card): Card not expand nested overlay-menu in touch devices
Mar 10, 2023
Nantawat-Poothong
changed the title
fix(card): Card not expand nested overlay-menu in touch devices
fix(card): Card can not expand nested overlay-menu in touch devices
Mar 10, 2023
Size Change: +26 B (0%) Total Size: 1.56 MB
ℹ️ View Unchanged
|
wattachai-lseg
requested changes
Mar 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things.
Co-authored-by: wattachai <[email protected]>
Deploying with Cloudflare Pages
|
…ition' into fix/card-overlay-menu-close-condition
wattachai-lseg
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Card can't expand nested overlay-menu in touch devices.
In mouse devices it work fine when hover the parent item to expand sub items.
But not for touch devices, it should tap the parent item to expand the sub items.
Root cause:
Solution:
Fixes # (issue)
https://jira.refinitiv.com/browse/STG-241
Type of change
Please delete options that are not relevant.
Checklist