-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uncheckAllItems method not update checked state of parent node #526
Merged
Sarin-Udompanish
merged 8 commits into
v6
from
fix/uncheck-all-method-not-update-parent-node
Nov 18, 2022
Merged
uncheckAllItems method not update checked state of parent node #526
Sarin-Udompanish
merged 8 commits into
v6
from
fix/uncheck-all-method-not-update-parent-node
Nov 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +68 B (0%) Total Size: 1.56 MB
ℹ️ View Unchanged
|
Deploying with Cloudflare Pages
|
…://github.com/Refinitiv/refinitiv-ui into fix/uncheck-all-method-not-update-parent-node
Sarin-Udompanish
requested review from
TremayneChrist
and removed request for
TremayneChrist
November 11, 2022 04:09
Nantawat-Poothong
approved these changes
Nov 17, 2022
Kudos, SonarCloud Quality Gate passed! |
Sarin-Udompanish
deleted the
fix/uncheck-all-method-not-update-parent-node
branch
November 18, 2022 03:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
uncheckAllItems
method insidetree-manager
calluncheckItem
method recursively and inside this method has condition to prevent update timestamp of descendent items so some parent of checked items will not be re-render.Live Demo:
https://codepen.io/mosmaall/pen/MWXpwRW?editors=1010
Steps to Reproduce:
Uncheck All By Public Method
button.Uncheck All By Public Method
orUncheck All By Set Empty values
button.Expected Results:
Parent Item of
ADF
should not in indeterminate state.Actual Results:
Parent Item of
ADF
is in indeterminate state.Type of change
Checklist