-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tab): trigger resize observer when label changes to make tab bar show scroll button correctly #480
Merged
Sarin-Udompanish
merged 3 commits into
v6
from
fix/tab-bar-not-resizing-correctly-when-label-changed
Oct 6, 2022
Merged
fix(tab): trigger resize observer when label changes to make tab bar show scroll button correctly #480
Sarin-Udompanish
merged 3 commits into
v6
from
fix/tab-bar-not-resizing-correctly-when-label-changed
Oct 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…show scroll button correctly
Size Change: +88 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
Deploying with Cloudflare Pages
|
Theeraphat-Sorasetsakul
approved these changes
Oct 6, 2022
Kudos, SonarCloud Quality Gate passed! |
Sarin-Udompanish
deleted the
fix/tab-bar-not-resizing-correctly-when-label-changed
branch
October 6, 2022 07:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tab-bar not show scroll button correctly when the label has been changed. This because ResizeObserver can't notice the change inside nested shadowRoot so we need to use workaround to trigger resize event.
Things to be reminds
Type of change
Checklist