-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(interactive-chart): fix left position on legend #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t has left y axis
Size Change: -61 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
Deploying with Cloudflare Pages
|
Co-authored-by: Nantawat Poothong <[email protected]>
…ui into fix/legend-position
…ui into fix/legend-position
SonarCloud Quality Gate failed. |
Nantawat-Poothong
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The legend is overlap the left y-axis when the width of y-axis is too large.
Here an error link: https://codepen.io/sirirats/pen/yLKYRQd?editors=1010
Fixes # (ELF-1931)
Solution:
Add callback to calculate Legend's left position when the chart has left y-axis. The callback is subscribed to sizeChange event that attached on x-axis. The sizeChange event called when width or height is changed and called after rendered. Actually, legend relate to Y-axis but lightweight-chart doesn't have event for y-axis,
Type of change
Checklist