Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime-picker): inputs misalignment for Japanese and Chinese locales #373

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

Nantawat-Poothong
Copy link
Contributor

Description

Datetime picker input misalignment when typing Japan or China language.

Solution

  • add line-height property to datetime-picker

Fixes # (issue)
https://jira.refinitiv.com/browse/ELF-1620

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 757d721
Status: ✅  Deploy successful!
Preview URL: https://e117a7f9.refinitiv-ui.pages.dev
Branch Preview URL: https://fix-datetime-picker-misalign.refinitiv-ui.pages.dev

View logs

@Nantawat-Poothong Nantawat-Poothong merged commit 337679b into v6 Jun 24, 2022
@Nantawat-Poothong Nantawat-Poothong deleted the fix/datetime-picker-misalignment branch June 24, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants