Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/datetime picker warning hover style #356

Merged
merged 7 commits into from
Jun 14, 2022

Conversation

Sarin-Udompanish
Copy link
Collaborator

@Sarin-Udompanish Sarin-Udompanish commented Jun 8, 2022

Description

ef-datetime-picker has incorrect border styles on warning and error states.
This changes will made datetime-picker has the same styles as ef-text-field.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 9, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 23c5580
Status: ✅  Deploy successful!
Preview URL: https://9af8f555.refinitiv-ui.pages.dev
Branch Preview URL: https://fix-datetime-picker-warning-.refinitiv-ui.pages.dev

View logs

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Sarin-Udompanish Sarin-Udompanish merged commit 51638bd into v6 Jun 14, 2022
@Sarin-Udompanish Sarin-Udompanish deleted the fix/datetime-picker-warning-hover-style branch June 14, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants