fix(autosuggest): add default min-width to autosuggest when loading #348
Conversation
Nantawat-Poothong
changed the title
| @@ -52,7 +53,7 @@ | |||
|
|
|||
| [part=backdrop] { | |||
| background-color: @overlay-background-color; | |||
| opacity: @overlay-opacity; | |||
There was a problem hiding this comment.
Why did you override this?
There was a problem hiding this comment.
The style looks wrong to me. Not sure if reuse overlay-opacity here is a right choice. I mean we may keep the same opacity but change background color instead if it's better solution.
There was a problem hiding this comment.
It is wrong all together: being the loader too large and the background too grey. Perhaps we need a proper solution from Design/UX on how to cover this case (and all other cases with asynchronous popup loading). This code was just migrated from v3 where it made more sense.
There was a problem hiding this comment.
maybe UX can say that entire screen needs to be greyed out, so we can deprecated autosuggest loading :)
There was a problem hiding this comment.
I'll go with this small improvement. It's better than today anyway. You know we would need to wait very long until they take an action. It means that users won't see any improvement until then :)
There was a problem hiding this comment.
Updated!, I have revert override backdrop opacity :)
Deploying with
|
| Latest commit: |
8bcb04d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a71a06e4.refinitiv-ui.pages.dev |
|
Kudos, SonarCloud Quality Gate passed!
|
Description
In case autosuggest asynchronous with mask, If we didn't set default min-width for autosuggest, the result when opening autosuggest is the mask didn't show, because autosuggest width doesn't set.
Fixes # (issue)
https://jira.refinitiv.com/browse/ELF-1845