Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list): clicking on item should focus on list itself #272

Merged
merged 37 commits into from
Jul 19, 2022
Merged

fix(list): clicking on item should focus on list itself #272

merged 37 commits into from
Jul 19, 2022

Conversation

wsuwt
Copy link
Collaborator

@wsuwt wsuwt commented Apr 7, 2022 •
edited
Loading

Description

When an item is clicked, it gets focused. This makes tabbing sequence wrong. Instead, focus should only remain at list.

So I propose this re-focus solution. However, this solution might be a problem when user wants to custom render and add certain event listener when an item is clicked.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 7, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ef4bfa4
Status: ✅  Deploy successful!
Preview URL: https://eabef5bf.refinitiv-ui.pages.dev
Branch Preview URL: https://fix-list-focus.refinitiv-ui.pages.dev

View logs

@wsuwt wsuwt self-assigned this Apr 8, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wsuwt wsuwt added the bug Something isn't working label Jul 1, 2022
@wsuwt wsuwt force-pushed the fix-list-focus branch from 460eb6d to 4498ffa Compare July 7, 2022 10:03
@wsuwt wsuwt marked this pull request as ready for review July 12, 2022 13:38
@wsuwt wsuwt requested a review from TremayneChrist July 14, 2022 10:41
@TremayneChrist
Copy link
Collaborator

Just needs the test coverage to be fixed

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dtanp-rft dtanp-rft self-requested a review July 19, 2022 10:09
@wsuwt wsuwt merged commit e2293e3 into v6 Jul 19, 2022
@wsuwt wsuwt deleted the fix-list-focus branch July 19, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtanp-rft dtanp-rft dtanp-rft approved these changes

@Sakchai-Refinitiv Sakchai-Refinitiv Awaiting requested review from Sakchai-Refinitiv

@TremayneChrist TremayneChrist Awaiting requested review from TremayneChrist

Assignees

@wsuwt wsuwt

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wsuwt @TremayneChrist @dtanp-rft @Sakchai-Refinitiv @phetw