Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/pagination handle input number with string #142

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Fix/pagination handle input number with string #142

merged 2 commits into from
Jan 4, 2022

Conversation

Theeraphat-Sorasetsakul
Copy link
Collaborator

@Theeraphat-Sorasetsakul Theeraphat-Sorasetsakul commented Jan 4, 2022 •
edited
Loading

Description

Refer to #77 (review)
Trem found a bug that value will to be '1' when user input '8.t' (any number with string).

Step to reproduce:

  1. Log to know the current value
  2. Set as user input by '8.t' or any number with string.
  3. Value will be '1' that expected result should be ignore changing.

Expected Results:

The value should be ignore changing.

Actual Results:

The value set to be '1'.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@Theeraphat-Sorasetsakul
Copy link
Collaborator Author

cc. @TremayneChrist @Sakchai-Refinitiv

@Theeraphat-Sorasetsakul Theeraphat-Sorasetsakul mentioned this pull request Jan 4, 2022
Merged
9 tasks
@Theeraphat-Sorasetsakul Theeraphat-Sorasetsakul merged commit 975f999 into develop Jan 4, 2022
@Theeraphat-Sorasetsakul Theeraphat-Sorasetsakul deleted the fix/pagination-handle-input-number-with-string branch January 4, 2022 09:48
wsuwt added a commit that referenced this pull request Jan 10, 2022
@wsuwt @Sakchai-Refinitiv
@Theeraphat-Sorasetsakul @refinitiv-ui-dev @dtanp-rft @Sarin-Udompanish
feat: upgrade to lit 2.1.1 to fix skypack issue (#151)
ab77b89 
* refactor(pagination): remove part info

* feat(pagination): support max unknown

* refactor(pagination): remove unused function `pageInfo`

* refactor(pagination): handle input page selection

* refactor(pagination): add state for check input is editing

* refactor(pagination): request update element on blur

* test(pagination): update transform text input selected test case

* refactor(pagination): use state decorator to auto update the input

* refactor(pagination): deprecate page, totalItems, page-changed (#78)

* chore(pagination): add max attribute demo

* test: fix test all fail when using setTimeout

* refactor(pagination): update getter setter and internal value

* chore(pagination): update demo page

* refactor(pagination): update internal max and property change events

* fix(pagination): max limit does not work

* refactor(pagination): validate value is in supported range

* refactor(pagination): add range value validation

* refactor(pagination): add deprecation notice on getter

* docs(pagination): remove type from jsdoc

* test(pagination): update to support value, max properties

* fix(pagination): getter in internal will retrigger incorrect warning message

* refactor(pagination): reset input behavior for end users

* refactor(pagination): reset input behavior for developers

* test(pagination): refactor unit test

* refactor(pagination): refactor innternal value and warning message

* refactor(pagination): remove unnecessary blur input

* test(pagination): update test case to support value and max approach

* refactor(pagination): use getter for toggle button state

* test(pagination): refactor unit-test

* chore(pagination): remove demo for testing

* fix(pagination): tab on the input to set a value

* fix(pagination): the input does not get disable state from the root

* test(pagination): add test case interaction when page is over

* test(pagination): fix typo

* test(pagination): remove unexpected attribute in snapshot

* refactor(pagination): cast type for text input

* refactor(pagination): remove unused interface

* chore(pagination): fix indent js doc incorrect

* fix(pagination): remove warning when set correct type value

* fix(pagiantion): convert prop toString in setter

* fix(pagination): add missing feature blur to set page from the input

* refactor(pagination): getter setter of max and page should be string

* chore(release): publish [skip ci]

 - @refinitiv-ui/[email protected]

* fix(halo-theme): fix backward compat with current import native-element path

* fix(themes): ignore hover styles on mobile device (#129)

Co-authored-by: Theeraphat-Sorasetsakul <[email protected]>

* chore(release): publish [skip ci]

 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]

* chore: add incremental to TypeScript compiler option for faster subsequent builds (#136)

* chore: add `incremental` to TypeScript compiler option for faster subsequent builds

* chore: update lock-file

* ci: create `GitHub release` and curated CHANGELOG on release (#137)

* chore(polyfills): remove exports and entrypoints (#141)

* chore(polyfills): remove exports and entrypoints

* chore(polyfills): change all.js to index.js

Co-authored-by: Wasuwat Limsuparhat <[email protected]>

* ci: use multiple stage pipeline for the test workflow (#140)

* fix(pagination): handle case when user input number with string (#142)

* fix: release script should not be publish to NPM (#144)

* chore: add development mode to dev-server so that developers can see  the warnings (#147)

* feat: upgrade to Lit 2.1.1

Co-authored-by: Sakchai Homhual <[email protected]>
Co-authored-by: Theeraphat-Sorasetsakul <[email protected]>
Co-authored-by: Theeraphat Sorasetsakul <[email protected]>
Co-authored-by: Sakchai Homhual <[email protected]>
Co-authored-by: refinitiv-ui-dev <[email protected]>
Co-authored-by: Domrongpon Tanpaibul <[email protected]>
Co-authored-by: dtanp <[email protected]>
Co-authored-by: Sarin-Udompanish <[email protected]>
TremayneChrist added a commit that referenced this pull request Jan 27, 2022
@TremayneChrist @Sakchai-Refinitiv
@Theeraphat-Sorasetsakul @refinitiv-ui-dev @dtanp-rft @Sarin-Udompanish @wsuwt @Jidapa-Pai @bualoy-napat @phetw @dependabot @goremikins
feat(*): use peer dependencies and simplify exports (#182)
6e76aab 
* refactor(pagination): remove part info

* feat(pagination): support max unknown

* refactor(pagination): remove unused function `pageInfo`

* refactor(pagination): handle input page selection

* refactor(pagination): add state for check input is editing

* refactor(pagination): request update element on blur

* test(pagination): update transform text input selected test case

* refactor(pagination): use state decorator to auto update the input

* refactor(pagination): deprecate page, totalItems, page-changed (#78)

* chore(pagination): add max attribute demo

* test: fix test all fail when using setTimeout

* refactor(pagination): update getter setter and internal value

* chore(pagination): update demo page

* refactor(pagination): update internal max and property change events

* fix(pagination): max limit does not work

* refactor(pagination): validate value is in supported range

* refactor(pagination): add range value validation

* refactor(pagination): add deprecation notice on getter

* docs(pagination): remove type from jsdoc

* test(pagination): update to support value, max properties

* fix(pagination): getter in internal will retrigger incorrect warning message

* refactor(pagination): reset input behavior for end users

* refactor(pagination): reset input behavior for developers

* test(pagination): refactor unit test

* refactor(pagination): refactor innternal value and warning message

* refactor(pagination): remove unnecessary blur input

* test(pagination): update test case to support value and max approach

* refactor(pagination): use getter for toggle button state

* test(pagination): refactor unit-test

* chore(pagination): remove demo for testing

* fix(pagination): tab on the input to set a value

* fix(pagination): the input does not get disable state from the root

* test(pagination): add test case interaction when page is over

* test(pagination): fix typo

* test(pagination): remove unexpected attribute in snapshot

* refactor(pagination): cast type for text input

* refactor(pagination): remove unused interface

* chore(pagination): fix indent js doc incorrect

* fix(pagination): remove warning when set correct type value

* fix(pagiantion): convert prop toString in setter

* fix(pagination): add missing feature blur to set page from the input

* refactor(pagination): getter setter of max and page should be string

* chore(release): publish [skip ci]

 - @refinitiv-ui/[email protected]

* fix(halo-theme): fix backward compat with current import native-element path

* fix(themes): ignore hover styles on mobile device (#129)

Co-authored-by: Theeraphat-Sorasetsakul <[email protected]>

* chore(release): publish [skip ci]

 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]

* chore: add incremental to TypeScript compiler option for faster subsequent builds (#136)

* chore: add `incremental` to TypeScript compiler option for faster subsequent builds

* chore: update lock-file

* ci: create `GitHub release` and curated CHANGELOG on release (#137)

* chore(polyfills): remove exports and entrypoints (#141)

* chore(polyfills): remove exports and entrypoints

* chore(polyfills): change all.js to index.js

Co-authored-by: Wasuwat Limsuparhat <[email protected]>

* ci: use multiple stage pipeline for the test workflow (#140)

* fix(pagination): handle case when user input number with string (#142)

* fix: release script should not be publish to NPM (#144)

* chore: add development mode to dev-server so that developers can see  the warnings (#147)

* chore: fix broken status badge (#154)

* Chore/add framework integration samples (#153)

* Chore/sample react app (#148)

* docs: init react sample app

* feat: add form handler

* fix: change native styles import path

* chore: change import path

* test: revise test case

* test: fix wrong expect value test case

* test: change test case name

* chore: fix intent and code styling

* chore: change import path

* chore: remove logo file

* docs: init vanilla sample app (#152)

* chore: sample angular app (#150)

* docs: init angular sample app

* chore: sample vue app

Co-authored-by: Theeraphat-Sorasetsakul <[email protected]>
Co-authored-by: Jidapa-Pai <[email protected]>
Co-authored-by: Napat Bualoy <[email protected]>

* fix(checkbox): `Enter` key should not check or uncheck checkbox

* fix(radio-button): `Enter` key should not check or uncheck radio-button

* test(checkbox): update `Enter` keypress test

* test(radio-button): update `Enter` keypress test

* chore(deps): bump postcss from 7.0.39 to 8.2.13 (#155)

chore(deps): bump autoprefixer from 9.6.5 to 10.4.2

* feat: upgrade `lit` to 2.1.1 (#156)

* fix(radio-button): add IE11 arrow keys navigation support (#158)

* chore: revert web-server development mode (#162)

* chore(release): publish [skip ci]

 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]

* feat(tree): improve screen reader support (#102)

* feat(list): improve screen reader

* feat(list): add aria-multiselectable for screen reader

* test(list): improve key control cases

* test(tree): update snapshots for tree

* feat(tree): add roles to tree and treee-item and add aria-expanded

* fix: add more generic type to default role for extendibility

* refactor: use setAttribute instead of overriding AOM properties

* refactor: aria expanded and selected logics

* feat: add aria level and setsize support

* feat: remove asterick key support

* feat: used aria-checked for multiple mode to indicate indeterminate state

* chore: update lock file

* refactor: simplify aria setting logics

* feat: add generic type to treeitem defaulRole

* fix: handles multiple mode changes

* test(tree): update snapshots

* refactor: reflect aria-selected according to selected state

* refactor: move most of the aria setting logics to tree-item element

* refactor: remove aria-setsize as it's no longer needed

Co-authored-by: Jidapa-Pai <[email protected]>
Co-authored-by: Jidapa-Pai <[email protected]>

* fix(tree-select): remove unnecessary x-scrollbar on default styles (#166)

* fix(checkbox): wrong cursor style when hover the end of checkbox label (#165)

fix(checkbox): wrong cursor style when hover the end of checkbox label

* Include ef documentation into monorepo (#146)

* docs: include EF documentation into monorepo

Co-authored-by: Sarin Udompanish <[email protected]>
Co-authored-by: Napat Bualoy <[email protected]>
Co-authored-by: Theeraphat Sorasetsakul <[email protected]>
Co-authored-by: Jidapa-Pai <[email protected]>
Co-authored-by: wsuwt <[email protected]>
Co-authored-by: Wasuwat Limsuparhat <[email protected]>

* docs: resize home page images appropriately (#169)

* chore(release): publish [skip ci] (#171)

- @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]

Co-authored-by: refinitiv-ui-dev <[email protected]>

* feat(collapse): add accessibility support (#161)

* Revert "feat(collapse): add accessibility support (#161)" (#179)

This reverts commit 158f031.

* chore(*): update package lock

* refactor(*): move peers into peerDependencies (#178)

* refactor(*): move peers into peerDependencies

* chore(*): print npm version

* chore(*): update package lock

* fix(*): trial custom npm build

* fix(*): build utils before core

* chore(core): move utils to peerDependencies

* chore(*): update release build commands

* Add types versions  (#183)

* refactor(core): rename elf.ts to index.ts to ensure default importing
refactor(utils): rename utils.ts to index.ts to ensure default importing
refactor(core): simplify package exports to remove `lib` path support
refactor(utils): simplify package exports to remove `lib` path support
refactor(elements): simplify package exports to remove `lib` path support
refactor(phrasebook): simplify package exports to remove `lib` path support

* fix(*): be flexible with types versions

Co-authored-by: Tremayne Christ <[email protected]>

Co-authored-by: Aleksejs <[email protected]>

* chore(*): use node 16.x in prerelease script

* chore(*): test on prerelease branch

* test(core): replace elf.js with index.js

Co-authored-by: Sakchai Homhual <[email protected]>
Co-authored-by: Theeraphat-Sorasetsakul <[email protected]>
Co-authored-by: Theeraphat Sorasetsakul <[email protected]>
Co-authored-by: Sakchai Homhual <[email protected]>
Co-authored-by: refinitiv-ui-dev <[email protected]>
Co-authored-by: Domrongpon Tanpaibul <[email protected]>
Co-authored-by: dtanp <[email protected]>
Co-authored-by: Sarin-Udompanish <[email protected]>
Co-authored-by: Wasuwat Limsuparhat <[email protected]>
Co-authored-by: Jidapa-Pai <[email protected]>
Co-authored-by: Napat Bualoy <[email protected]>
Co-authored-by: wsuwt <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jidapa-Pai <[email protected]>
Co-authored-by: Sarin Udompanish <[email protected]>
Co-authored-by: Napat Bualoy <[email protected]>
Co-authored-by: Aleksejs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TremayneChrist TremayneChrist TremayneChrist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Theeraphat-Sorasetsakul @TremayneChrist