Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(combo-box): improve screen reader #116

Merged
merged 21 commits into from
Dec 15, 2021
Merged

feat(combo-box): improve screen reader #116

merged 21 commits into from
Dec 15, 2021

Conversation

Jidapa-Pai
Copy link
Contributor

@Jidapa-Pai Jidapa-Pai commented Dec 9, 2021 •
edited
Loading

Description

  • Add role=combobox on input element.
  • Add role=listbox on list element.
  • Add aria-expanded to indicate expand/collapsed state of each list
  • Using aria-activedescendant to manage focused option while Dom focus on input

Fixes # (issue)

  • Prevent keyboard action when combo-box is set to readonly.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Jidapa-Pai and others added 13 commits December 9, 2021 17:16
wsuwt
wsuwt reviewed Dec 14, 2021
View reviewed changes
packages/elements/src/combo-box/__snapshots__/AsyncFilter.md Outdated Show resolved Hide resolved
packages/elements/src/combo-box/__snapshots__/AsyncFilter.md Outdated Show resolved Hide resolved
packages/elements/src/combo-box/__snapshots__/Template.md Outdated Show resolved Hide resolved
packages/elements/src/combo-box/index.ts Outdated Show resolved Hide resolved
packages/elements/src/combo-box/index.ts Outdated Show resolved Hide resolved
packages/elements/src/combo-box/index.ts Show resolved Hide resolved
@wsuwt wsuwt marked this pull request as ready for review December 14, 2021 12:14
@wsuwt wsuwt force-pushed the accessibility/combo-box branch from 22a3ecc to aabbb36 Compare December 14, 2021 12:28
goremikins
goremikins reviewed Dec 14, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@goremikins
refactor: improve code style and remove unused references
380b0be 
* chore: rollback package.json
refactor(combo-box): improve the code
refactor(elemental-theme): use part selector for combo-box
refactor(solar-theme): use part selector for combo-box
refactor(halo-theme): use part selector for combo-box

* refactor(combo-box): use element reference
refactor(combo-box): remove text-field references
@wsuwt wsuwt merged commit f603de1 into develop Dec 15, 2021
@wsuwt wsuwt deleted the accessibility/combo-box branch December 15, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goremikins goremikins goremikins left review comments

@wsuwt wsuwt wsuwt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jidapa-Pai @goremikins @wsuwt @phetw