-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autosuggest): incorrect mark style #1071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
Size Change: -2.28 kB (0%) Total Size: 1.55 MB
ℹ️ View Unchanged
|
wattachai-lseg
requested review from
wattachai-lseg and
kosol-komenek-rft
and removed request for
wattachai-lseg
January 10, 2024 10:54
kosol-komenek-rft
previously approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good for me.
github-actions
bot
added
the
dependencies
Pull requests that update a dependency file
label
Jan 16, 2024
bualoy-napat
force-pushed
the
fix/autosuggest-incorrect-mark-style-v6
branch
from
January 17, 2024 08:52
591c0f3
to
75886ea
Compare
…Refinitiv/refinitiv-ui into fix/autosuggest-incorrect-mark-style-v6
bualoy-napat
removed
the
dependencies
Pull requests that update a dependency file
label
Jan 17, 2024
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
wattachai-lseg
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mark
color on suggestion list is not correct when attach theef-autosuggest
inside the shadow DOM. The root cause of this issue is that themark
element is not within the scope of theef-autosuggest
theme. It is slotted inside theef-item
. Therefore, moving themark
style to the scope ofef-item
will fix the issue.Fixes # (issue)
ELF-2366
Checklist