-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(slider): support custom label #1051
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
v6
EF version 6
labels
Dec 8, 2023
Sarin-Udompanish
changed the title
Feature/support custom labels v6
feat(slider): support custom label
Dec 8, 2023
Deploying with Cloudflare Pages
|
Size Change: -5.43 kB (0%) Total Size: 1.57 MB
ℹ️ View Unchanged
|
Co-authored-by: wattachai <[email protected]>
…/Refinitiv/refinitiv-ui into feature/support-custom-labels-v6
Kudos, SonarCloud Quality Gate passed! |
wattachai-lseg
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
v6
EF version 6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce new features on Slider to be able to define labels shown on the slider. The labels have nothing to do with markers when steps are defined. It's only showing label on the slider at specified value.
While label styles and label markers below require visual treatment and review from Design Team, it illustrates that users can configure label by using
ef-slider-marker
. Text content of the ef-slider-marker is optional. Users can omit the value if only label marker is required.Checklist