From c9a9f89cd10b1ab33b89dac9b89c20f7a8cebf92 Mon Sep 17 00:00:00 2001 From: Sakchai Homhual Date: Tue, 11 Oct 2022 15:30:01 +0700 Subject: [PATCH 1/6] ci: add more mobile browsers for testing --- browsers.config.js | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/browsers.config.js b/browsers.config.js index 1b221b5f6a..21869ccba6 100644 --- a/browsers.config.js +++ b/browsers.config.js @@ -28,7 +28,11 @@ const BrowserStack = { 'default', // default browsers alias 'supported', // supported browsers alias 'ios', - 'android' + 'android', + 'samsung', + 'ios_previous', + 'android_previous', + 'samsung_previous' ] }; // Copy supported browsers to available browsers @@ -57,8 +61,14 @@ BrowserStack.config = { safari_previous: { ...defaultOSX, browser: 'safari', os_version: 'Big Sur' }, // Mobile Devices - ios: { ...defaultDevice, device : 'iPhone 13', os: 'ios', os_version : '15.0' }, - android: { ...defaultDevice, device : 'Google Pixel 6', os: 'android', os_version : '12.0' } + ios: { ...defaultDevice, browser: 'iphone', device : 'iPhone 14', os: 'ios', os_version : '16' }, + android: { ...defaultDevice, browser: 'android', device : 'Google Pixel 6', os: 'android', os_version : '12.0' }, + samsung: { ...defaultDevice, browser: 'samsung', device : 'Samsung Galaxy S22', os: 'android', os_version : '12.0' }, + + // Mobile Devices Previous versions + ios_previous: { ...defaultDevice, browser: 'iphone', device : 'iPhone 13', os: 'ios', os_version : '15' }, + android_previous: { ...defaultDevice, browser: 'android', device : 'Google Pixel 5', os: 'android', os_version : '11.0' }, + samsung_previous: { ...defaultDevice, browser: 'samsung', device : 'Samsung Galaxy S21', os: 'android', os_version : '11.0' } }; module.exports = { From 388acd16fdf58538077b0a3237ab1536fdbf633e Mon Sep 17 00:00:00 2001 From: Sakchai Homhual Date: Tue, 11 Oct 2022 15:30:23 +0700 Subject: [PATCH 2/6] ci: add new test browserstack workflow --- .github/actions/run-test/action.yml | 11 ++ .github/workflows/test_browserstack.yml | 177 ++++++++++++++++++++++++ 2 files changed, 188 insertions(+) create mode 100644 .github/workflows/test_browserstack.yml diff --git a/.github/actions/run-test/action.yml b/.github/actions/run-test/action.yml index d44886e77e..31421f4229 100644 --- a/.github/actions/run-test/action.yml +++ b/.github/actions/run-test/action.yml @@ -11,6 +11,10 @@ inputs: description: 'Run test in all packages or only affected packages' required: false default: 'affected' # affected|all + target: + description: 'Run test on the package/element' + required: false + default: '' coverage: description: 'Include test coverage' required: false @@ -68,6 +72,7 @@ runs: echo "Updated" - name: Test + if: ${{ inputs.target == '' || inputs.target == 'all' }} shell: bash # Prevent NX caching for mode `all` because it must run all testing, even though the code has not changed. run: | @@ -75,6 +80,12 @@ runs: [[ "${{ inputs.mode }}" == "all" ]] && export OPTIONS="--skip-nx-cache" npm run test:${{ inputs.mode }} -- $OPTIONS --parallel=${{ inputs.parallel }} ${{ env.BROWSERS_OPTION }} --includeCoverage ${{ inputs.coverage }} --output minimal + - name: Test Package or Element + if: ${{ inputs.target != '' }} + shell: bash + run: | + npm run test ${{ inputs.target }} -- ${{ env.BROWSERS_OPTION }} --includeCoverage ${{ inputs.coverage }} + - name: BrowserStackLocal Stop # Terminating the BrowserStackLocal tunnel connection if: ${{ inputs.browserstack == 'true' }} uses: browserstack/github-actions/setup-local@master diff --git a/.github/workflows/test_browserstack.yml b/.github/workflows/test_browserstack.yml new file mode 100644 index 0000000000..83374d5cd9 --- /dev/null +++ b/.github/workflows/test_browserstack.yml @@ -0,0 +1,177 @@ +name: Test BrowserStack + +on: + workflow_dispatch: + inputs: + browsers: + description: 'Browsers' + required: true + type: choice + options: + # Alias browser groups + - default + - supported + # Desktop browsers + - chrome + - firefox + - safari + - edge + # Mobile browsers + - ios + - android + - samsung + # Previous version + - chrome_previous + - firefox_previous + - safari_previous + - edge_previous + - ios_previous + - android_previous + - samsung_previous + target: + description: 'Packages/Elements' + required: true + type: choice + options: + # Packages + - all + - core + - demo-block + - elements + - i18n + - phrasebook + - test-helpers + - translate + # Elements + - accordion + - appstate-bar + - autosuggest + - button + - button-bar + - calendar + - canvas + - card + - chart + - checkbox + - clock + - collapse + - color-dialog + - color-picker + - combo-box + - counter + - datetime-field + - datetime-picker + - dialog + - email-field + - flag + - header + - heatmap + - icon + - interactive-chart + - item + - label + - layout + - led-gauge + - list + - loader + - multi-input + - notification + - number-field + - overlay + - overlay-menu + - pagination + - panel + - password-field + - pill + - progress-bar + - radio-button + - rating + - search-field + - select + - sidebar-layout + - slider + - sparkline + - swing-gauge + - tab + - tab-bar + - text-field + - time-picker + - toggle + - tooltip + - tornado-chart + - tree + - tree-select + +env: + TARGET: ${{ inputs.target }} + BROWSERS: ${{ inputs.browsers }} + BROWSERSTACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }} + BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }} + BROWSERSTACK_BUILD: "Test BrowserStack ${{ github.run_number }}" + +jobs: + build: + runs-on: ubuntu-latest + steps: + + - name: Test Input + shell: bash + run: | + echo "TARGET1: $TARGET" + echo "TARGET2: ${{ env.TARGET }}" + + - name: Check out repository code + uses: actions/checkout@v2 + with: + fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis + + - name: Setup resources and environment + uses: ./.github/actions/setup + id: setup + + - name: Install Dependencies + if: steps.setup.outputs.cache-dependencies-hit != 'true' + run: npm ci --ignore-scripts --audit=false --fund=false + + - name: Reset NX # temporary + run: npm run reset + + - name: Build + if: steps.setup.outputs.cache-build-hit != 'true' + run: npm run build + + lint: + needs: build + runs-on: ubuntu-latest + steps: + - name: Check out repository code + uses: actions/checkout@v2 + with: + fetch-depth: 0 + + - name: Setup resources and environment + uses: ./.github/actions/setup + + - name: Lint + run: npm run lint:affected -- --base=$BASE_SHA + + test: + needs: lint + name: "Test ${{ github.event.inputs.target }} / ${{ github.event.inputs.browsers }} browser" + runs-on: ubuntu-latest + steps: + - name: Check out repository code + uses: actions/checkout@v2 + with: + fetch-depth: 0 + + - name: "Test on BrowserStack" + uses: ./.github/actions/run-test + with: + browsers: ${{ env.BROWSERS }} + target: ${{ env.TARGET }} + mode: 'all' + browserstack: 'true' + username: ${{ env.BROWSERSTACK_USERNAME }} + access-key: ${{ env.BROWSERSTACK_ACCESS_KEY }} + parallel: 3 From 2996851e0cd84274fbf284e9763298ce894b6a94 Mon Sep 17 00:00:00 2001 From: Domrongpon Tanpaibul <81604092+dtanp-rft@users.noreply.github.com> Date: Wed, 12 Oct 2022 15:06:34 +0700 Subject: [PATCH 3/6] fix: add minimum npm version (v7) to package.json (#500) * fix: add minimum npm version (v7) to package.json * fix: update theme output files * fix: error when run test --- packages/create-efx/template/package.json.template | 3 +++ packages/create-efx/template/src/efx-element.ts | 8 +++++--- packages/create-efx/template/test/efx-element.test.js | 2 +- .../create-efx/template/themes/halo/dark/efx-element.js | 2 +- .../template/themes/halo/dark/es5/all-elements.js | 2 +- packages/create-efx/template/themes/halo/efx-element.less | 6 ++++++ .../create-efx/template/themes/halo/light/efx-element.js | 2 +- .../template/themes/halo/light/es5/all-elements.js | 2 +- 8 files changed, 19 insertions(+), 8 deletions(-) diff --git a/packages/create-efx/template/package.json.template b/packages/create-efx/template/package.json.template index 3f5862d066..1b94c85ccc 100644 --- a/packages/create-efx/template/package.json.template +++ b/packages/create-efx/template/package.json.template @@ -9,6 +9,9 @@ "repository": "", "author": "Refinitiv", "license": "Apache-2.0", + "engines": { + "npm": "^7.0.0" + }, "scripts": { "start": "vite --open --base=/demo/", "build": "npm run build:themes && tsc --sourceMap --declarationMap", diff --git a/packages/create-efx/template/src/efx-element.ts b/packages/create-efx/template/src/efx-element.ts index ad5c66de80..8b567453a7 100644 --- a/packages/create-efx/template/src/efx-element.ts +++ b/packages/create-efx/template/src/efx-element.ts @@ -64,9 +64,11 @@ export class EfxElement extends BasicElement { protected render (): TemplateResult { return html` - - - +
+ + + +
count is ${this.count} diff --git a/packages/create-efx/template/test/efx-element.test.js b/packages/create-efx/template/test/efx-element.test.js index 4f24b2afc7..a5a0d43e43 100644 --- a/packages/create-efx/template/test/efx-element.test.js +++ b/packages/create-efx/template/test/efx-element.test.js @@ -4,7 +4,7 @@ import { fixture, expect } from '@refinitiv-ui/test-helpers'; // import element and theme import '../src/efx-element.ts'; -import '../themes/halo-theme/dark'; +import '../themes/halo/dark'; describe('EfxElementTest', () => { it('Label and DOM structure is correct', async () => { diff --git a/packages/create-efx/template/themes/halo/dark/efx-element.js b/packages/create-efx/template/themes/halo/dark/efx-element.js index 11617f44e3..94a4b78d7a 100644 --- a/packages/create-efx/template/themes/halo/dark/efx-element.js +++ b/packages/create-efx/template/themes/halo/dark/efx-element.js @@ -1,4 +1,4 @@ import './imports/native-elements.js'; -elf.customStyles.define('efx-element', ':host{max-width:500px}:host [part=container]{padding:20px}:host [part=logo]{height:6em;padding:1.5em;will-change:filter}:host [part=logo]:hover{filter:drop-shadow(0 0 2em #334bff)}:host [part=sub-title]{color:#6678ff}'); +elf.customStyles.define('efx-element', ':host{max-width:500px}:host [part=container]{padding:20px}:host [part=logo-container]{background-color:#fff;padding:10px;margin-bottom:20px}:host [part=logo]{height:6em;padding:1.5em;will-change:filter}:host [part=logo]:hover{filter:drop-shadow(0 0 2em #334bff)}:host [part=sub-title]{color:#6678ff}'); diff --git a/packages/create-efx/template/themes/halo/dark/es5/all-elements.js b/packages/create-efx/template/themes/halo/dark/es5/all-elements.js index 6d0e70255c..0329724b69 100644 --- a/packages/create-efx/template/themes/halo/dark/es5/all-elements.js +++ b/packages/create-efx/template/themes/halo/dark/es5/all-elements.js @@ -1,2 +1,2 @@ -elf.customStyles.define('efx-element', ':host{max-width:500px}:host [part=container]{padding:20px}:host [part=logo]{height:6em;padding:1.5em;will-change:filter}:host [part=logo]:hover{filter:drop-shadow(0 0 2em #334bff)}:host [part=sub-title]{color:#6678ff}'); +elf.customStyles.define('efx-element', ':host{max-width:500px}:host [part=container]{padding:20px}:host [part=logo-container]{background-color:#fff;padding:10px;margin-bottom:20px}:host [part=logo]{height:6em;padding:1.5em;will-change:filter}:host [part=logo]:hover{filter:drop-shadow(0 0 2em #334bff)}:host [part=sub-title]{color:#6678ff}'); diff --git a/packages/create-efx/template/themes/halo/efx-element.less b/packages/create-efx/template/themes/halo/efx-element.less index 0f3dfb094d..1f0dc5c0ba 100644 --- a/packages/create-efx/template/themes/halo/efx-element.less +++ b/packages/create-efx/template/themes/halo/efx-element.less @@ -12,6 +12,12 @@ INSTRUCTIONS [part=container] { padding: 20px; } + + [part=logo-container] { + background-color: white; + padding: 10px; + margin-bottom: 20px; + } [part=logo] { height: 6em; diff --git a/packages/create-efx/template/themes/halo/light/efx-element.js b/packages/create-efx/template/themes/halo/light/efx-element.js index 11617f44e3..94a4b78d7a 100644 --- a/packages/create-efx/template/themes/halo/light/efx-element.js +++ b/packages/create-efx/template/themes/halo/light/efx-element.js @@ -1,4 +1,4 @@ import './imports/native-elements.js'; -elf.customStyles.define('efx-element', ':host{max-width:500px}:host [part=container]{padding:20px}:host [part=logo]{height:6em;padding:1.5em;will-change:filter}:host [part=logo]:hover{filter:drop-shadow(0 0 2em #334bff)}:host [part=sub-title]{color:#6678ff}'); +elf.customStyles.define('efx-element', ':host{max-width:500px}:host [part=container]{padding:20px}:host [part=logo-container]{background-color:#fff;padding:10px;margin-bottom:20px}:host [part=logo]{height:6em;padding:1.5em;will-change:filter}:host [part=logo]:hover{filter:drop-shadow(0 0 2em #334bff)}:host [part=sub-title]{color:#6678ff}'); diff --git a/packages/create-efx/template/themes/halo/light/es5/all-elements.js b/packages/create-efx/template/themes/halo/light/es5/all-elements.js index 6d0e70255c..0329724b69 100644 --- a/packages/create-efx/template/themes/halo/light/es5/all-elements.js +++ b/packages/create-efx/template/themes/halo/light/es5/all-elements.js @@ -1,2 +1,2 @@ -elf.customStyles.define('efx-element', ':host{max-width:500px}:host [part=container]{padding:20px}:host [part=logo]{height:6em;padding:1.5em;will-change:filter}:host [part=logo]:hover{filter:drop-shadow(0 0 2em #334bff)}:host [part=sub-title]{color:#6678ff}'); +elf.customStyles.define('efx-element', ':host{max-width:500px}:host [part=container]{padding:20px}:host [part=logo-container]{background-color:#fff;padding:10px;margin-bottom:20px}:host [part=logo]{height:6em;padding:1.5em;will-change:filter}:host [part=logo]:hover{filter:drop-shadow(0 0 2em #334bff)}:host [part=sub-title]{color:#6678ff}'); From 16bd2856ab415f3d977252044c8bbb8ec494f1f3 Mon Sep 17 00:00:00 2001 From: Nantawat Poothong <102957966+Nantawat-Poothong@users.noreply.github.com> Date: Wed, 12 Oct 2022 17:45:15 +0700 Subject: [PATCH 4/6] docs(tutorial): update framework webpack tutorial (#499) * docs(tutorial): remove duplicate webpack import path * docs(tutorial): add mention to vanilla webpack4 * docs(tutorial): update wording Co-authored-by: Wasuwat Limsuparhat <86233706+wsuwt@users.noreply.github.com> * docs(tutorial): update wording Co-authored-by: Wasuwat Limsuparhat <86233706+wsuwt@users.noreply.github.com> --- .../build-app/framework-integration/angular.md | 18 +----------------- .../build-app/framework-integration/vue.md | 18 +----------------- 2 files changed, 2 insertions(+), 34 deletions(-) diff --git a/documents/src/pages/build-app/framework-integration/angular.md b/documents/src/pages/build-app/framework-integration/angular.md index c1e3f714b8..d2ab005689 100644 --- a/documents/src/pages/build-app/framework-integration/angular.md +++ b/documents/src/pages/build-app/framework-integration/angular.md @@ -85,23 +85,7 @@ import '@refinitiv-ui/elements/panel/themes/halo/dark'; import '@refinitiv-ui/elements/text-field/themes/halo/dark'; import '@refinitiv-ui/elements/password-field/themes/halo/dark'; ``` - -If you're using Angular 13++ or using Webpack 5, you can import module by using a shorter path. - -```javascript -import '@refinitiv-ui/elements/loader'; -import '@refinitiv-ui/elements/button'; -import '@refinitiv-ui/elements/panel'; -import '@refinitiv-ui/elements/text-field'; -import '@refinitiv-ui/elements/password-field'; - -import '@refinitiv-ui/halo-theme/dark/imports/native-elements'; -import '@refinitiv-ui/elements/loader/themes/halo/dark'; -import '@refinitiv-ui/elements/button/themes/halo/dark'; -import '@refinitiv-ui/elements/panel/themes/halo/dark'; -import '@refinitiv-ui/elements/text-field/themes/halo/dark'; -import '@refinitiv-ui/elements/password-field/themes/halo/dark'; -``` +If you're using webpack 4, you can set path aliases in `webpack.config.js` similar to [Vanilla](./tutorials/vanilla-js#webpack-4). At this stage EF elements should be ready to use!. You can use them like any other native HTML elements. diff --git a/documents/src/pages/build-app/framework-integration/vue.md b/documents/src/pages/build-app/framework-integration/vue.md index 5859948f79..96194b8250 100644 --- a/documents/src/pages/build-app/framework-integration/vue.md +++ b/documents/src/pages/build-app/framework-integration/vue.md @@ -59,23 +59,7 @@ import '@refinitiv-ui/elements/panel/themes/halo/dark'; import '@refinitiv-ui/elements/text-field/themes/halo/dark'; import '@refinitiv-ui/elements/password-field/themes/halo/dark'; ``` - -If you're already migrated or using Webpack 5, you can import module by using a shorter path. - -```javascript -import '@refinitiv-ui/elements/loader'; -import '@refinitiv-ui/elements/button'; -import '@refinitiv-ui/elements/panel'; -import '@refinitiv-ui/elements/text-field'; -import '@refinitiv-ui/elements/password-field'; - -import '@refinitiv-ui/halo-theme/dark/imports/native-elements'; -import '@refinitiv-ui/elements/loader/themes/halo/dark'; -import '@refinitiv-ui/elements/button/themes/halo/dark'; -import '@refinitiv-ui/elements/panel/themes/halo/dark'; -import '@refinitiv-ui/elements/text-field/themes/halo/dark'; -import '@refinitiv-ui/elements/password-field/themes/halo/dark'; -``` +If you're using webpack 4, you can set path aliases in `webpack.config.js` similar to [Vanilla](./tutorials/vanilla-js#webpack-4). Components can be used like any other native `HTMLElement`. Try replacing content in `src/App.vue` with the code below. From fa89a1b36750c499e086d619c37f494120c41915 Mon Sep 17 00:00:00 2001 From: Sakchai Homhual <87511654+Sakchai-Refinitiv@users.noreply.github.com> Date: Tue, 18 Oct 2022 14:20:16 +0700 Subject: [PATCH 5/6] ci: update actions checkout and cache to v3 (#493) --- .github/actions/setup/action.yml | 4 ++-- .github/workflows/dev_release.yml | 2 +- .github/workflows/pre_release.yml | 2 +- .github/workflows/prod_release.yml | 2 +- .github/workflows/test.yml | 6 +++--- .github/workflows/test_browserstack.yml | 6 +++--- .github/workflows/test_coverage.yml | 4 ++-- .github/workflows/test_nightly.yml | 6 +++--- 8 files changed, 16 insertions(+), 16 deletions(-) diff --git a/.github/actions/setup/action.yml b/.github/actions/setup/action.yml index ae1294655a..2052c49c86 100644 --- a/.github/actions/setup/action.yml +++ b/.github/actions/setup/action.yml @@ -18,7 +18,7 @@ runs: node-version: 16.x - name: Setup caching dependencies - uses: actions/cache@v2 + uses: actions/cache@v3 id: cache-npm with: path: | @@ -29,7 +29,7 @@ runs: restore-keys: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }} - name: Setup caching build - uses: actions/cache@v2 + uses: actions/cache@v3 id: cache-build with: path: | diff --git a/.github/workflows/dev_release.yml b/.github/workflows/dev_release.yml index 030ef3c9b0..08edec933d 100644 --- a/.github/workflows/dev_release.yml +++ b/.github/workflows/dev_release.yml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out repository code - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: # Number of commits to fetch. 0 indicates all history for all branches and tags. # Pulls all commits (needed for Lerna) diff --git a/.github/workflows/pre_release.yml b/.github/workflows/pre_release.yml index 6143108e0f..958eb47040 100644 --- a/.github/workflows/pre_release.yml +++ b/.github/workflows/pre_release.yml @@ -20,7 +20,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out repository code - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: # Number of commits to fetch. 0 indicates all history for all branches and tags. # Pulls all commits (needed for Lerna) diff --git a/.github/workflows/prod_release.yml b/.github/workflows/prod_release.yml index 8f47b23c86..42f6d94cde 100644 --- a/.github/workflows/prod_release.yml +++ b/.github/workflows/prod_release.yml @@ -16,7 +16,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out repository code - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: # Number of commits to fetch. 0 indicates all history for all branches and tags. # Pulls all commits (needed for Lerna) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 22891a4b20..98d9b8658b 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out repository code - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: # Number of commits to fetch. 0 indicates all history for all branches and tags. # Pulls all commits (needed for Lerna) @@ -38,7 +38,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out repository code - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: fetch-depth: 0 @@ -53,7 +53,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out repository code - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: fetch-depth: 0 diff --git a/.github/workflows/test_browserstack.yml b/.github/workflows/test_browserstack.yml index 83374d5cd9..efc9f252b9 100644 --- a/.github/workflows/test_browserstack.yml +++ b/.github/workflows/test_browserstack.yml @@ -121,7 +121,7 @@ jobs: echo "TARGET2: ${{ env.TARGET }}" - name: Check out repository code - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis @@ -145,7 +145,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out repository code - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: fetch-depth: 0 @@ -161,7 +161,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out repository code - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: fetch-depth: 0 diff --git a/.github/workflows/test_coverage.yml b/.github/workflows/test_coverage.yml index 11c00b9151..22038f3b6c 100644 --- a/.github/workflows/test_coverage.yml +++ b/.github/workflows/test_coverage.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out repository code - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis @@ -37,7 +37,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out repository code - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: fetch-depth: 0 diff --git a/.github/workflows/test_nightly.yml b/.github/workflows/test_nightly.yml index 05c416e175..586748f836 100644 --- a/.github/workflows/test_nightly.yml +++ b/.github/workflows/test_nightly.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out repository code - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: # Number of commits to fetch. 0 indicates all history for all branches and tags. # Pulls all commits (needed for Lerna) @@ -38,7 +38,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out repository code - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: fetch-depth: 0 @@ -54,7 +54,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out repository code - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: fetch-depth: 0 From 3c7275b477830be9021784aa2cd30bb6bf8f10fd Mon Sep 17 00:00:00 2001 From: Theeraphat-Sorasetsakul <86758473+Theeraphat-Sorasetsakul@users.noreply.github.com> Date: Thu, 20 Oct 2022 10:13:58 +0700 Subject: [PATCH 6/6] docs(color-dialog): remove ts-ignore comment due to typescript4.4 bug (#504) --- packages/elements/src/color-dialog/elements/palettes.ts | 6 ------ 1 file changed, 6 deletions(-) diff --git a/packages/elements/src/color-dialog/elements/palettes.ts b/packages/elements/src/color-dialog/elements/palettes.ts index d668ee67f8..7fe06fd7a1 100644 --- a/packages/elements/src/color-dialog/elements/palettes.ts +++ b/packages/elements/src/color-dialog/elements/palettes.ts @@ -107,12 +107,6 @@ export class Palettes extends BasicElement { */ protected onTouchmove (event: TouchEvent): void { const touchOffsets = event.changedTouches[0]; - - // TODO: it is a bug of TypeScript@4.4 remove ts-ignore once it is fixed - // https://github.com/microsoft/TypeScript/issues/45047 - // eslint-disable-next-line @typescript-eslint/ban-ts-comment - // @ts-ignore - // eslint-disable-next-line @typescript-eslint/no-unsafe-call const realTarget = this.shadowRoot?.elementFromPoint(touchOffsets.clientX, touchOffsets.clientY) as SVGAElement; this.updateValue(realTarget); }