Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image welcome message. #109

Merged
merged 17 commits into from
Oct 4, 2022
Merged

Image welcome message. #109

merged 17 commits into from
Oct 4, 2022

Conversation

DxsSucuk
Copy link
Member

@DxsSucuk DxsSucuk commented Sep 15, 2022 •
edited
Loading

Pull Request Etiquette

Changes

  • Internal code
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

This PR will allow us to give Users the option to use custom Images at the join Messages.

@DxsSucuk DxsSucuk mentioned this pull request Sep 15, 2022
Closed
23 tasks
@DxsSucuk DxsSucuk added enhancement Request for the improvement of an feature feature A new feature p2 Medium priority. labels Sep 15, 2022
@DxsSucuk DxsSucuk modified the milestones: 1.9.7, 1.10.0 Sep 17, 2022
@DxsSucuk
Copy link
Member Author

DxsSucuk commented Oct 4, 2022 •
edited
Loading

This is actually finished.
I might document the command since it is easier to use and add automatic line break if the message is too long and would go over.

@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.6% 0.6% Duplication

@DxsSucuk DxsSucuk merged commit b03375a into master Oct 4, 2022
@DxsSucuk DxsSucuk deleted the feature/join-image branch October 4, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Request for the improvement of an feature feature A new feature p2 Medium priority.
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
1 participant
@DxsSucuk