Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Language System. #108

Merged
merged 24 commits into from
Oct 7, 2022
Merged

Multi-Language System. #108

merged 24 commits into from
Oct 7, 2022

Conversation

DxsSucuk
Copy link
Member

Pull Request Etiquette

Changes

  • Internal code
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

This PR allows access to multiple language packs which can allow no english speakers to use Ree6 without Issues!

Already implemented it on some places.
@DxsSucuk DxsSucuk mentioned this pull request Sep 15, 2022
23 tasks
@DxsSucuk DxsSucuk added feature A new feature p2 Medium priority. labels Sep 15, 2022
@DxsSucuk DxsSucuk added this to the 1.10.0 milestone Sep 17, 2022
@DenuxPlays
Copy link
Contributor

What if you use google spreadsheet (download this as a csv file) instead of yml files.
You dont have to make a commit to update a typo for example.
You can update the file for every start of the bot.
Anyone can have read access to it an it would be easier to find typos for people who dont know programming.
And you dont need any file parsee/serializer for that. You can do it in pure java.

@DxsSucuk
Copy link
Member Author

DxsSucuk commented Oct 4, 2022

What if you use google spreadsheet (download this as a csv file) instead of yml files.

Thats a interesting Idea I might look into it!

You dont have to make a commit to update a typo for example. You can update the file for every start of the bot. Anyone can have read access to it an it would be easier to find typos for people who dont know programming.

The YAML file is read only and will be "directly streamed" into the bots Language Manager, which means that if a typo gets fixed you only need to restart the bot.

Thank you for the input, as of right now the System is mostly a "proof-of-concept", there will be alot of changes and I will consider using csv files as supported language file!
@DenuxPlays

@DenuxPlays
Copy link
Contributor

Yes but with google spreadsheet (or any other service where you can download as csv) you can easily access it from everywhere.
I can build the csv system for you it is really simple or I can make a concept of it if you want.
@DxsSucuk

@DenuxPlays
Copy link
Contributor

You can contact me on Discord if you want to talk about it.

@DxsSucuk
Copy link
Member Author

DxsSucuk commented Oct 4, 2022

Yes but with google spreadsheet (or any other service where you can download as csv) you can easily access it from everywhere.

The Language file is easily accessible since all of them are in one directory which will be on the main branch after merge. https://github.com/Ree6-Applications/Ree6/tree/feature/multi-language/languages

I can build the csv system for you it is really simple or I can make a concept of it if you want.

Feel free to fork Ree6 and implement it 👍

@DenuxPlays

@DenuxPlays
Copy link
Contributor

Feel free to fork Ree6 and implement it 👍

Ok will start today when I am home.

@DxsSucuk DxsSucuk modified the milestones: 1.10.0, 2.0.0 Oct 5, 2022
@DxsSucuk
Copy link
Member Author

DxsSucuk commented Oct 5, 2022

This PR will be merge with V2 after finishing it.

@DxsSucuk DxsSucuk changed the base branch from master to v2 October 5, 2022 23:33
@DxsSucuk
Copy link
Member Author

DxsSucuk commented Oct 7, 2022

Should be all ready now, just gotta document everything.

@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

@DxsSucuk DxsSucuk merged commit ab702fe into v2 Oct 7, 2022
@DxsSucuk DxsSucuk deleted the feature/multi-language branch October 7, 2022 12:02
@DxsSucuk DxsSucuk modified the milestones: 2.x.x, 2.0.0 Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature p2 Medium priority.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants