Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from json-schema-ref-parser's bundle method to dereference #380

Closed
wants to merge 1 commit into from
Closed

Conversation

c0dingn0mad
Copy link

Fix / work-around for Issue 311

@RomanHotsiy
Copy link
Member

@vegyraupe thanks for this PR.
But it makes unit tests fail. I will investigate though.
But, could you please verify if the issue #113 still occurs on the 2.0.0-alpha.1.
It is complete ReDoc rewrite using React so the issue may be fixed now.

Thanks!

@c0dingn0mad
Copy link
Author

@RomanGotsiy I tried with alpha.5 and the error still occurs. Switching bundle to dereference works again. The problem occurs when the same external reference is being used twice. This results in bundle to only include it once and returning a relative reference instead of the dereferenced object.

@RomanHotsiy
Copy link
Member

@vegyraupe could you share your spec? or at least minimal reproducible sample?

@RomanHotsiy
Copy link
Member

Closing this as stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants