Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add handle for local files #1810

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

AlexVarchuk
Copy link
Collaborator

What/Why/How?

fixes #1793

Reference

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

Copy link
Member

@RomanHotsiy RomanHotsiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, can we reuse openapi-cli preview-docs somehow here?

Maybe we should deprecate server command and ask people to use openapi-cli?

@AlexVarchuk what do you think?

@AlexVarchuk
Copy link
Collaborator Author

Hmmm, can we reuse openapi-cli preview-docs somehow here?
Maybe we should deprecate server command and ask people to use openapi-cli?

Good idea. I'll investigate it. Thanks

@AlexVarchuk AlexVarchuk self-assigned this Mar 18, 2022
@AlexVarchuk AlexVarchuk marked this pull request as ready for review March 21, 2022 11:08
@AlexVarchuk AlexVarchuk merged commit 117071e into master Mar 21, 2022
@AlexVarchuk AlexVarchuk deleted the fix/cli-serve-not-handle-local-file branch March 21, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not serve local files
3 participants