Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Array size info based on min max Items properties #1308

Merged
merged 1 commit into from
Jun 27, 2020

Conversation

mosheeshel
Copy link
Contributor

@mosheeshel mosheeshel commented Jun 25, 2020

Encountered this issue in our spec, trying to fix according to suggestion in issue.

This is my first attempt to contribute to redoc (or any TypeScript/JavaScript project) - I hope I'm in the right direction, but I can't seem to build the project locally - tests are failing (on a clean master repo), so please be gentle.

If you can point me to how to add a test for this behavior, I'll gladly do that too.

@mosheeshel
Copy link
Contributor Author

mosheeshel commented Jun 25, 2020

@adamaltman this is according to your comments here #1131

@RomanHotsiy RomanHotsiy merged commit 644e96a into Redocly:master Jun 27, 2020
@RomanHotsiy
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants