Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add the --title option to the serve subcommand #1160

Merged
merged 1 commit into from
May 9, 2020
Merged

feat(cli): add the --title option to the serve subcommand #1160

merged 1 commit into from
May 9, 2020

Conversation

ZakCodes
Copy link
Contributor

As mentioned in this comment, the --title option was never implemented for the serve subcommand.

Here are my 3 test cases to show that it works:

No title provided

OpenAPI Spec
openapi: 3.0.0
info: {}
  # title: Title omitted from the file
paths: {}
Command
redoc-cli serve spec.yml
Expected title

ReDoc Documentation

Title provided in the file

OpenAPI Spec
openapi: 3.0.0
info:
  title: Title given in the file
paths: {}
Command
redoc-cli serve spec.yml
Expected title

Title given in the file

Title provided to the command

OpenAPI Spec
openapi: 3.0.0
info: {}
  # title: Title omitted from the file
paths: {}
Command
redoc-cli serve spec.yml --title "Title given to the command"
Expected title

Title given to the command

Title provided in the file and to the command

OpenAPI Spec
openapi: 3.0.0
info:
  title: Title given in the file
paths: {}
Command
redoc-cli serve spec.yml --title "Title given to the command"
Expected title

Title given to the command

@RomanHotsiy RomanHotsiy merged commit 10414fc into Redocly:master May 9, 2020
@RomanHotsiy
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants