feat(cli): add the --title option to the serve subcommand #1160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this comment, the
--title
option was never implemented for theserve
subcommand.Here are my 3 test cases to show that it works:
No title provided
OpenAPI Spec
Command
Expected title
ReDoc Documentation
Title provided in the file
OpenAPI Spec
Command
Expected title
Title given in the file
Title provided to the command
OpenAPI Spec
Command
redoc-cli serve spec.yml --title "Title given to the command"
Expected title
Title given to the command
Title provided in the file and to the command
OpenAPI Spec
Command
redoc-cli serve spec.yml --title "Title given to the command"
Expected title
Title given to the command