Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support initialization from a Redis connection String #34

Closed
lpellegr opened this issue Nov 5, 2020 · 1 comment · Fixed by #40
Closed

Support initialization from a Redis connection String #34

lpellegr opened this issue Nov 5, 2020 · 1 comment · Fixed by #40
Labels
help wanted Extra attention is needed

Comments

@lpellegr
Copy link

lpellegr commented Nov 5, 2020

This client library does not support initializing a client from a connection string or URI. For instance, in an app I am working on, I receive a Redis connection string as input. Due to the lack of support for such input in the client library, I have to parse the String by myself or change the way connection data are passed.

All libraries I know support passing a connection String to initialize a connection to a database. Adding support should be quite easy since the underlying Jedis library that is used supports the use case. If you agree to fix this issue, the main issue is whether you prefer to support a String, a URI, or both as input.

@gkorland
Copy link
Contributor

gkorland commented Nov 6, 2020

To avoid duplicating all the Jedis settings we added this construction, that allows you to pass a Jedis pool that is configured the way you want it.

public RedisTimeSeries​(redis.clients.jedis.util.Pool<redis.clients.jedis.Jedis> pool)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants