Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix artifact naming #591

Merged
merged 2 commits into from
Jan 6, 2025
Merged

fix artifact naming #591

merged 2 commits into from
Jan 6, 2025

Conversation

GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented Jan 5, 2025

Changes in the pull request

  1. Remove node16 workaround (not valid anymore)
  2. Move artifact name generation to before running any test (so we don't skip running it)
  3. Improve job and artifact names

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.09%. Comparing base (3291f63) to head (228bb84).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #591   +/-   ##
=======================================
  Coverage   97.09%   97.09%           
=======================================
  Files         104      104           
  Lines        5503     5503           
=======================================
  Hits         5343     5343           
  Misses        160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

meiravgri
meiravgri previously approved these changes Jan 5, 2025
@GuyAv46 GuyAv46 added this pull request to the merge queue Jan 5, 2025
@meiravgri meiravgri removed this pull request from the merge queue due to a manual request Jan 5, 2025
@GuyAv46 GuyAv46 added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 5df57b2 Jan 6, 2025
16 checks passed
@GuyAv46 GuyAv46 deleted the guyav-fix_CI_artifact_names branch January 6, 2025 17:17
Copy link

github-actions bot commented Jan 6, 2025

Successfully created backport PR for 0.8:

github-actions bot pushed a commit that referenced this pull request Jan 6, 2025
* fix artifact naming

* improve name format

(cherry picked from commit 5df57b2)
github-actions bot pushed a commit that referenced this pull request Jan 6, 2025
* fix artifact naming

* improve name format

(cherry picked from commit 5df57b2)
Copy link

github-actions bot commented Jan 6, 2025

Successfully created backport PR for 8.0:

github-merge-queue bot pushed a commit that referenced this pull request Jan 6, 2025
fix artifact naming (#591)

* fix artifact naming

* improve name format

(cherry picked from commit 5df57b2)

Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jan 6, 2025
fix artifact naming (#591)

* fix artifact naming

* improve name format

(cherry picked from commit 5df57b2)

Co-authored-by: GuyAv46 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants