-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve updatable heap - [MOD-5439] #434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
==========================================
- Coverage 95.37% 95.37% -0.01%
==========================================
Files 66 66
Lines 4151 4148 -3
==========================================
- Hits 3959 3956 -3
Misses 192 192 ☔ View full report in Codecov by Sentry. |
alonre24
previously approved these changes
Feb 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 25, 2024
GuyAv46
force-pushed
the
guyav-improve_updatable_heap
branch
from
February 25, 2024 13:36
b0bfc5f
to
4d3df4e
Compare
alonre24
approved these changes
Feb 25, 2024
GuyAv46
changed the title
Improve updatable heap - [MOD-5489]
Improve updatable heap - [MOD-5439]
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Replacing the
valueToPriority
unordered map of the updatable heap withvalueToNode
.Instead of having a multimap from priority to values, and an unordered map from value to priority, we will have the same multimap, but with a map from value to its node in the multimap. This way we have less lookup work to do when updating a value's priority.
Additional changes:
Mark if applicable