Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve updatable heap - [MOD-5439] #434

Merged
merged 4 commits into from
Feb 25, 2024
Merged

Conversation

GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented Feb 22, 2024

Describe the changes in the pull request

Replacing the valueToPriority unordered map of the updatable heap with valueToNode.

Instead of having a multimap from priority to values, and an unordered map from value to priority, we will have the same multimap, but with a map from value to its node in the multimap. This way we have less lookup work to do when updating a value's priority.

Additional changes:

  1. Replacing empty destructors with default (good practice)
  2. Simplifying formatting script

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.37%. Comparing base (182b87a) to head (4d3df4e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
- Coverage   95.37%   95.37%   -0.01%     
==========================================
  Files          66       66              
  Lines        4151     4148       -3     
==========================================
- Hits         3959     3956       -3     
  Misses        192      192              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

alonre24
alonre24 previously approved these changes Feb 25, 2024
@GuyAv46 GuyAv46 added this pull request to the merge queue Feb 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 25, 2024
@GuyAv46 GuyAv46 enabled auto-merge February 25, 2024 13:27
@GuyAv46 GuyAv46 requested a review from alonre24 February 25, 2024 13:27
@GuyAv46 GuyAv46 force-pushed the guyav-improve_updatable_heap branch from b0bfc5f to 4d3df4e Compare February 25, 2024 13:36
@GuyAv46 GuyAv46 added this pull request to the merge queue Feb 25, 2024
@GuyAv46 GuyAv46 changed the title Improve updatable heap Improve updatable heap - [MOD-5489] Feb 25, 2024
Merged via the queue into main with commit 956e54f Feb 25, 2024
27 checks passed
@GuyAv46 GuyAv46 deleted the guyav-improve_updatable_heap branch February 25, 2024 15:55
@GuyAv46 GuyAv46 changed the title Improve updatable heap - [MOD-5489] Improve updatable heap - [MOD-5439] Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants